Layout Test http/wpt/beacon/beacon-async-error-logging.html is flaky

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Matt Lewis]

The following layout test is flaky on WK2

http/wpt/beacon/beacon-async-error-logging.html

Probable cause:

This doesn't currently have a clear regression point.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fbeacon%2Fbeacon-async-error-logging.html

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r227682%20(2547)/results.html
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/builds/2547

diff:

--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/beacon/beacon-async-error-logging-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/beacon/beacon-async-error-logging-actual.txt
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: Beacon API cannot load http://invalid.localhost/. A server with the specified hostname could not be found.
 
 PASS Should log an error message in the console

[Radar WebKit Bug Importer]

<rdar://problem/36929478>

[Chris Dumez]

Don't worry about the regression point. The test currently relies on a setTimeout. I'll fix.

[Chris Dumez]

Created attachment 332430 [details]
WIP Patch

[Chris Dumez]

Created attachment 332449 [details]
Patch

[youenn fablet]

Comment on attachment 332449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332449&action=review

> LayoutTests/http/wpt/beacon/beacon-async-error-logging.html:10
> +        internals.setConsoleMessageListener(function() {

Can we make it sort of working on regular environment by testing for window.internals and adding a text message stating to look for console message?

[Chris Dumez]

Created attachment 332451 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 332451 [details]
Patch

Clearing flags on attachment: 332451

Committed r227712: <https://trac.webkit.org/changeset/227712>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.