Bug 182184

Summary: Layout Test http/wpt/beacon/beacon-async-error-logging.html is flaky
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, lforschler, rniwa, ryanhaddad, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
Patch
none
Patch none

Matt Lewis
Reported 2018-01-26 13:11:46 PST
The following layout test is flaky on WK2 http/wpt/beacon/beacon-async-error-logging.html Probable cause: This doesn't currently have a clear regression point. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fbeacon%2Fbeacon-async-error-logging.html https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r227682%20(2547)/results.html https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/builds/2547 diff: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/beacon/beacon-async-error-logging-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/beacon/beacon-async-error-logging-actual.txt @@ -1,4 +1,3 @@ -CONSOLE MESSAGE: Beacon API cannot load http://invalid.localhost/. A server with the specified hostname could not be found. PASS Should log an error message in the console
Attachments
WIP Patch (767 bytes, patch)
2018-01-26 16:49 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (1.65 KB, patch)
2018-01-26 19:01 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (1.77 KB, patch)
2018-01-26 19:49 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-26 16:43:43 PST
<rdar://problem/36929478>
Chris Dumez
Comment 2 2018-01-26 16:46:05 PST
Don't worry about the regression point. The test currently relies on a setTimeout. I'll fix.
Chris Dumez
Comment 3 2018-01-26 16:49:26 PST
Created attachment 332430 [details] WIP Patch
Chris Dumez
Comment 4 2018-01-26 19:01:32 PST
Created attachment 332449 [details] Patch
youenn fablet
Comment 5 2018-01-26 19:44:34 PST
Comment on attachment 332449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332449&action=review > LayoutTests/http/wpt/beacon/beacon-async-error-logging.html:10 > + internals.setConsoleMessageListener(function() { Can we make it sort of working on regular environment by testing for window.internals and adding a text message stating to look for console message?
Chris Dumez
Comment 6 2018-01-26 19:49:55 PST
Created attachment 332451 [details] Patch
WebKit Commit Bot
Comment 7 2018-01-26 20:26:15 PST
Comment on attachment 332451 [details] Patch Clearing flags on attachment: 332451 Committed r227712: <https://trac.webkit.org/changeset/227712>
WebKit Commit Bot
Comment 8 2018-01-26 20:26:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.