Bug 182180

Summary:

We should only append ParserArenaDeletable pointers to ParserArena::m_deletableObjects.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	msaboff: review+

Description Mark Lam 2018-01-26 12:16:16 PST

<rdar://problem/36460697>

Comment 1 Mark Lam 2018-01-26 12:25:22 PST

Created attachment 332401 [details]
proposed patch.

Comment 2 Michael Saboff 2018-01-26 12:56:25 PST

Comment on attachment 332401 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=332401&action=review

r=me

> Source/JavaScriptCore/parser/Nodes.h:1698
> +        // ScopeNode is never instantiate. The life-cycle of its derived classes are

Change this to ScopeNode is never *directly instantiated*.

Comment 3 Mark Lam 2018-01-26 13:15:06 PST

Thanks for the review.  Landed in r227692: <http://trac.webkit.org/r227692>.