Bug 182162

Summary: Web Inspector: "Displayed Columns" should not be displayed in context menu if all columns are required columns
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2018-01-25 20:09:59 PST
"Displayed Columns" should not be displayed in context menu if all columns are required columns * Steps to reproduce 1. Inspect <http://webkit.org> 2. Show Network Tab 3. Select a resource with cookie data (reload if needed) 4. Select the Cookie tab 5. Right-click the column header for Request Cookies => Context menu should not have "Displayed Columns" header since no columns can be toggled
Attachments
[PATCH] Proposed Fix (1.99 KB, patch)
2018-01-25 20:14 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2018-01-25 20:10:10 PST
<rdar://problem/36893758>
Joseph Pecoraro
Comment 2 2018-01-25 20:14:26 PST
Created attachment 332347 [details] [PATCH] Proposed Fix
Matt Baker
Comment 3 2018-01-25 20:35:12 PST
Comment on attachment 332347 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 4 2018-01-25 20:58:38 PST
Comment on attachment 332347 [details] [PATCH] Proposed Fix Clearing flags on attachment: 332347 Committed r227652: <https://trac.webkit.org/changeset/227652>
WebKit Commit Bot
Comment 5 2018-01-25 20:58:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.