Bug 182134

Summary:

ServiceWorkerClientFetch should not consider responses without Location headers as redirection responses

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Service Workers

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, cdumez, commit-queue, ews-watchlist, jlewis3, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=182311

Bug Depends on:

182193

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Patch	none

youenn fablet

Reported 2018-01-25 12:09:33 PST

ServiceWorkerClientFetch should not consider responses without Location headers as redirection responses

Attachments
Patch (6.86 KB, patch) 2018-01-25 12:12 PST, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.03 MB, application/zip) 2018-01-25 13:12 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.15 MB, application/zip) 2018-01-25 13:43 PST, EWS Watchlist	no flags	Details
Patch (7.56 KB, patch) 2018-01-26 16:58 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-01-25 12:12:40 PST

Created attachment 332296 [details] Patch

Radar WebKit Bug Importer

Comment 2 2018-01-25 12:36:24 PST

<rdar://problem/36878770>

Chris Dumez

Comment 3 2018-01-25 12:41:45 PST

Comment on attachment 332296 [details] Patch r=me

EWS Watchlist

Comment 4 2018-01-25 13:12:11 PST

Comment on attachment 332296 [details] Patch Attachment 332296 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6211908 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https.html

EWS Watchlist

Comment 5 2018-01-25 13:12:12 PST

Created attachment 332304 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-01-25 13:43:48 PST

Comment on attachment 332296 [details] Patch Attachment 332296 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6212000 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https.html

EWS Watchlist

Comment 7 2018-01-25 13:43:49 PST

Created attachment 332309 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

youenn fablet

Comment 8 2018-01-26 16:58:49 PST

Created attachment 332432 [details] Patch

WebKit Commit Bot

Comment 9 2018-01-29 18:15:19 PST

Comment on attachment 332432 [details] Patch Clearing flags on attachment: 332432 Committed r227770: <https://trac.webkit.org/changeset/227770>

WebKit Commit Bot

Comment 10 2018-01-29 18:15:21 PST

All reviewed patches have been landed. Closing bug.

Matt Lewis

Comment 11 2018-01-30 11:01:22 PST

This is failing on macOS with the occasional crash and is crashing on iOS simulator Debug and failing on iOS Release fairly consistently. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Fnavigation-redirect.https.html https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r227790%20(2861)/results.html https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/builds/2861

Matt Lewis

Comment 12 2018-01-30 11:03:04 PST

It looks like the crash this test is hitting is the same in: https://bugs.webkit.org/show_bug.cgi?id=182054

youenn fablet

Comment 13 2018-01-30 11:09:20 PST

(In reply to Matt Lewis from comment #12) > It looks like the crash this test is hitting is the same in: > https://bugs.webkit.org/show_bug.cgi?id=182054 That makes sense. Before the patch, the patch was skipped. With the patch, the test runs successfully and uses message ports internally to help testing.

Note You need to log in before you can comment on or make changes to this bug.