Bug 182131

Summary: [webkitpy] Config file for apache is copied twice.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: Tools / TestsAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, bfulgham, commit-queue, dbates, ews-watchlist, glenn, jbedard, lforschler, pvollan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
fix none

Basuke Suzuki
Reported 2018-01-25 12:06:50 PST
Config file is copied in _get_apache_config_file_path(), but it is called twice.
Attachments
fix (2.62 KB, patch)
2018-01-25 12:16 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-01-25 12:16:49 PST
Created attachment 332297 [details] fix
Daniel Bates
Comment 2 2018-01-30 20:14:37 PST
Comment on attachment 332297 [details] fix View in context: https://bugs.webkit.org/attachment.cgi?id=332297&action=review > Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:95 > + '-f', "\"%s\"" % config_file_path, It would be good to understand why we need to copy the config file to begin with. This is unrelated to your patch.
WebKit Commit Bot
Comment 3 2018-01-30 20:27:46 PST
Comment on attachment 332297 [details] fix Clearing flags on attachment: 332297 Committed r227871: <https://trac.webkit.org/changeset/227871>
WebKit Commit Bot
Comment 4 2018-01-30 20:27:47 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-01-30 20:28:21 PST
<rdar://problem/37054960>
Basuke Suzuki
Comment 6 2018-01-31 10:06:29 PST
> It would be good to understand why we need to copy the config file to begin > with. This is unrelated to your patch. Agreed. Who has the context of this? My guess is that somebody had tried to modify config file to configure, but later passing them by arguments was okay and accepted. Then coping just left as is.
Note You need to log in before you can comment on or make changes to this bug.