Summary: | [webkitpy] Config file for apache is copied twice. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> | ||||
Component: | Tools / Tests | Assignee: | Basuke Suzuki <Basuke.Suzuki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, Basuke.Suzuki, bfulgham, commit-queue, dbates, ews-watchlist, glenn, jbedard, lforschler, pvollan, rniwa, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Basuke Suzuki
2018-01-25 12:06:50 PST
Created attachment 332297 [details]
fix
Comment on attachment 332297 [details] fix View in context: https://bugs.webkit.org/attachment.cgi?id=332297&action=review > Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:95 > + '-f', "\"%s\"" % config_file_path, It would be good to understand why we need to copy the config file to begin with. This is unrelated to your patch. Comment on attachment 332297 [details] fix Clearing flags on attachment: 332297 Committed r227871: <https://trac.webkit.org/changeset/227871> All reviewed patches have been landed. Closing bug. > It would be good to understand why we need to copy the config file to begin
> with. This is unrelated to your patch.
Agreed. Who has the context of this? My guess is that somebody had tried to modify config file to configure, but later passing them by arguments was okay and accepted. Then coping just left as is.
|