Bug 182116

Summary: Make sure we have a frame as we iterate in ResourceLoadObserver::nonNullOwnerURL()
Product: WebKit Reporter: John Wilander <wilander>
Component: WebCore Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, dbates, ews-watchlist, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch achristensen: review+

John Wilander
Reported 2018-01-25 11:34:20 PST
We need to check that we have a frame before using it as we traverse the frame hierarchy up to find a non-null URL in ResourceLoadObserver::nonNullOwnerURL().
Attachments
Patch (1.43 KB, patch)
2018-01-25 11:39 PST, John Wilander 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Wilander
Comment 1 2018-01-25 11:34:40 PST
rdar://problem/36210134
John Wilander
Comment 2 2018-01-25 11:39:11 PST
Created attachment 332294 [details] Patch
John Wilander
Comment 3 2018-01-25 11:46:04 PST
In the case where we don't have a frame, the returned URL is empty which through the call to ResourceLoadStatistics::primaryDomain() becomes "nullOrigin".
John Wilander
Comment 4 2018-01-25 14:31:21 PST
Committed r227632: <https://trac.webkit.org/changeset/227632>
John Wilander
Comment 5 2018-01-25 14:31:36 PST
Thanks, Alex!
Note You need to log in before you can comment on or make changes to this bug.