Bug 182102

Summary: [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, ews-watchlist, gustavo, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cgarcia: review+, cgarcia: commit-queue-

Sergio Villar Senin
Reported 2018-01-25 07:39:40 PST
[WebVR][GTK][WPE] Remove the WebVR public API added in r227518
Attachments
Patch (6.11 KB, patch)
2018-01-25 07:40 PST, Sergio Villar Senin 		cgarcia: review+
cgarcia: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2018-01-25 07:40:25 PST
Created attachment 332265 [details] Patch
EWS Watchlist
Comment 2 2018-01-25 07:41:20 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2018-01-25 07:45:02 PST
Comment on attachment 332265 [details] Patch Remember the changes in MB too. Thanks!
Sergio Villar Senin
Comment 4 2018-01-25 07:47:51 PST
Right I forgot to remove that too. Thanks for the quick review
Sergio Villar Senin
Comment 5 2018-01-25 07:52:12 PST
I also removed the new API from the docs
Sergio Villar Senin
Comment 6 2018-01-25 07:52:27 PST
Committed r227607: <https://trac.webkit.org/changeset/227607>
Radar WebKit Bug Importer
Comment 7 2018-01-25 07:53:15 PST
<rdar://problem/36868357>
Michael Catanzaro
Comment 8 2018-01-25 09:59:23 PST
Careful with prepare-ChangeLog! It's annoying; I usually double-check it before landing, and still forget sometimes....
Note You need to log in before you can comment on or make changes to this bug.