Summary: | [Cairo] Use GraphicsContextImplCairo in Nicosia::PaintingContextCairo | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cgarcia, ews-watchlist, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Zan Dobersek
2018-01-25 02:44:38 PST
Created attachment 332245 [details]
Patch
Attachment 332245 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/nicosia/NicosiaPaintingContextCairo.cpp:73: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] WARNING: This machine could support 4 simulators, but is only configured for 3. WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>. Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. Comment on attachment 332245 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332245&action=review > Source/WebCore/platform/graphics/nicosia/NicosiaPaintingContextCairo.cpp:76 > + m_graphicsContext = std::make_unique<WebCore::GraphicsContext>( > + [this](WebCore::GraphicsContext& context) > + { > + return std::make_unique<WebCore::GraphicsContextImplCairo>(context, *m_platformContext); > + }); Fix the indentation here. Created attachment 332252 [details]
Patch for landing
Comment on attachment 332252 [details] Patch for landing Clearing flags on attachment: 332252 Committed r227599: <https://trac.webkit.org/changeset/227599> All reviewed patches have been landed. Closing bug. |