| Summary: | Move ImageDecoderAVFObjC from using AVSampleBufferGenerator to AVAssetReaderOutput for parsing | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, rniwa, webkit-bug-importer | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Jer Noble
2018-01-25 01:24:11 PST
Created attachment 332239 [details]
Patch
Attachment 332239 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:46: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:81: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] WARNING: This machine could support 4 simulators, but is only configured for 3. WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>. Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. Comment on attachment 332239 [details] Patch Attachment 332239 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6205611 New failing tests: fast/images/animated-image-mp4.html http/tests/images/image-supports-video.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html Created attachment 332241 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 332239 [details] Patch Attachment 332239 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6206268 New failing tests: fast/images/animated-image-mp4.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html Created attachment 332255 [details]
Archive of layout-test-results from ews113 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 332239 [details] Patch Attachment 332239 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6206941 New failing tests: fast/images/animated-image-mp4.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html Created attachment 332258 [details]
Archive of layout-test-results from ews114 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 332271 [details]
Patch
Attachment 332271 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:46: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:81: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] WARNING: This machine could support 4 simulators, but is only configured for 3. WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>. Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style. Comment on attachment 332271 [details] Patch Attachment 332271 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6209392 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html Created attachment 332278 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 332280 [details]
Patch
Attachment 332280 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:46: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:81: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 2 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 332282 [details]
Patch
Attachment 332282 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:46: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:81: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 2 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 332282 [details] Patch Clearing flags on attachment: 332282 Committed r227631: <https://trac.webkit.org/changeset/227631> All reviewed patches have been landed. Closing bug. |