Bug 182091

Summary:

Move ImageDecoderAVFObjC from using AVSampleBufferGenerator to AVAssetReaderOutput for parsing

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews113 for mac-sierra	none
Archive of layout-test-results from ews114 for mac-sierra	none
Patch	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch	none
Patch	none

Jer Noble

Reported 2018-01-25 01:24:11 PST

Move ImageDecoderAVFObjC from using AVSampleBufferGenerator to AVAssetReaderOutput for parsing

Attachments
Patch (29.04 KB, patch) 2018-01-25 01:29 PST, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.27 MB, application/zip) 2018-01-25 02:34 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-sierra (2.92 MB, application/zip) 2018-01-25 03:55 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-sierra (2.95 MB, application/zip) 2018-01-25 05:02 PST, EWS Watchlist	no flags	Details
Patch (30.08 KB, patch) 2018-01-25 08:34 PST, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.14 MB, application/zip) 2018-01-25 10:17 PST, EWS Watchlist	no flags	Details
Patch (29.87 KB, patch) 2018-01-25 10:29 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch (40.13 KB, patch) 2018-01-25 10:32 PST, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2018-01-25 01:29:08 PST

Created attachment 332239 [details] Patch

EWS Watchlist

Comment 2 2018-01-25 01:30:00 PST Comment hidden (obsolete)

Attachment 332239 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:46: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:81: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] WARNING: This machine could support 4 simulators, but is only configured for 3. WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>. Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 3 2018-01-25 02:34:18 PST Comment hidden (obsolete)

Comment on attachment 332239 [details] Patch Attachment 332239 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6205611 New failing tests: fast/images/animated-image-mp4.html http/tests/images/image-supports-video.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html

EWS Watchlist

Comment 4 2018-01-25 02:34:19 PST Comment hidden (obsolete)

Created attachment 332241 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-01-25 03:55:56 PST Comment hidden (obsolete)

Comment on attachment 332239 [details] Patch Attachment 332239 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6206268 New failing tests: fast/images/animated-image-mp4.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html

EWS Watchlist

Comment 6 2018-01-25 03:55:57 PST Comment hidden (obsolete)

Created attachment 332255 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-01-25 05:02:36 PST Comment hidden (obsolete)

Comment on attachment 332239 [details] Patch Attachment 332239 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6206941 New failing tests: fast/images/animated-image-mp4.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html

EWS Watchlist

Comment 8 2018-01-25 05:02:37 PST Comment hidden (obsolete)

Created attachment 332258 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6

Jer Noble

Comment 9 2018-01-25 08:34:33 PST

Created attachment 332271 [details] Patch

EWS Watchlist

Comment 10 2018-01-25 08:36:07 PST Comment hidden (obsolete)

Attachment 332271 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:46: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:81: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] WARNING: This machine could support 4 simulators, but is only configured for 3. WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>. Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 11 2018-01-25 10:17:08 PST Comment hidden (obsolete)

Comment on attachment 332271 [details] Patch Attachment 332271 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6209392 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html

EWS Watchlist

Comment 12 2018-01-25 10:17:09 PST Comment hidden (obsolete)

Created attachment 332278 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Jer Noble

Comment 13 2018-01-25 10:29:28 PST

Created attachment 332280 [details] Patch

EWS Watchlist

Comment 14 2018-01-25 10:31:09 PST Comment hidden (obsolete)

Attachment 332280 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:46: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:81: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jer Noble

Comment 15 2018-01-25 10:32:42 PST

Created attachment 332282 [details] Patch

EWS Watchlist

Comment 16 2018-01-25 10:34:20 PST

Attachment 332282 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:46: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:81: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jer Noble

Comment 17 2018-01-25 14:17:52 PST

<rdar://problem/36882492>

WebKit Commit Bot

Comment 18 2018-01-25 14:30:00 PST

Comment on attachment 332282 [details] Patch Clearing flags on attachment: 332282 Committed r227631: <https://trac.webkit.org/changeset/227631>

WebKit Commit Bot

Comment 19 2018-01-25 14:30:01 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.