Bug 182087

Summary: [css-multicol] Update WPT test suite
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Tools / TestsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: fred.wang, jfernandez, lforschler, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Rebased patch
none
Rebased patch
none
Manually generated .diff
none
New try
none
Another try
none
One more time none

Manuel Rego Casasnovas
Reported 2018-01-25 00:19:07 PST
Now that the suite is in the proper folder (bug #182044), we can update it.
Attachments
Patch (273.06 KB, patch)
2018-01-25 00:22 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Rebased patch (273.10 KB, patch)
2018-01-25 00:29 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Rebased patch (273.09 KB, patch)
2018-01-25 02:42 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Manually generated .diff (263.27 KB, patch)
2018-01-25 02:58 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
New try (273.09 KB, patch)
2018-01-25 03:29 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Another try (272.46 KB, patch)
2018-01-25 03:44 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
One more time (262.70 KB, patch)
2018-01-25 03:52 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2018-01-25 00:22:21 PST
Created attachment 332234 [details] Patch
Javier Fernandez
Comment 2 2018-01-25 00:26:16 PST
Comment on attachment 332234 [details] Patch The patch does not apply, though.
Manuel Rego Casasnovas
Comment 3 2018-01-25 00:29:43 PST
Created attachment 332235 [details] Rebased patch
Manuel Rego Casasnovas
Comment 4 2018-01-25 02:42:47 PST
Created attachment 332243 [details] Rebased patch
Manuel Rego Casasnovas
Comment 5 2018-01-25 02:58:33 PST
Created attachment 332247 [details] Manually generated .diff Trying to generate manually the patch to pass EWS.
Manuel Rego Casasnovas
Comment 6 2018-01-25 03:29:21 PST
Created attachment 332250 [details] New try
Manuel Rego Casasnovas
Comment 7 2018-01-25 03:44:11 PST
Created attachment 332251 [details] Another try
Manuel Rego Casasnovas
Comment 8 2018-01-25 03:52:33 PST
Created attachment 332254 [details] One more time
Manuel Rego Casasnovas
Comment 9 2018-01-25 05:26:55 PST
Committed r227600: <https://trac.webkit.org/changeset/227600>
Manuel Rego Casasnovas
Comment 10 2018-01-25 07:39:29 PST
I finally landed this manually as I didn't managed to get it applied on EWSs (it seems an issue with white spaces and newlines...). And some tests were failing in Mac, so I marked them in TestExpectations accordingly: https://trac.webkit.org/changeset/227605 I didn't realize before because they were already marked as failures in GTK+ port, sorry about that.
Radar WebKit Bug Importer
Comment 11 2018-01-25 07:39:50 PST
<rdar://problem/36867933>
Note You need to log in before you can comment on or make changes to this bug.