Bug 182044 - Move css-color & css-multicol WPT suites to the proper folder
Summary: Move css-color & css-multicol WPT suites to the proper folder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords: InRadar
Depends on:
Blocks: 182004
  Show dependency treegraph
 
Reported: 2018-01-24 04:33 PST by Manuel Rego Casasnovas
Modified: 2018-01-24 23:20 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.52 MB, patch)
2018-01-24 04:35 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Rebased patch (1.46 MB, patch)
2018-01-24 08:01 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch for landing (1.46 MB, patch)
2018-01-24 22:59 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2018-01-24 04:33:47 PST
These suites were still under LayoutTests/imported/w3c/css/,
when actually they should be under LayoutTests/imported/w3c/web-platform-tests/css/.
Comment 1 Manuel Rego Casasnovas 2018-01-24 04:35:21 PST
Created attachment 332147 [details]
Patch
Comment 2 youenn fablet 2018-01-24 06:26:25 PST
Does not apply.
Comment 3 Manuel Rego Casasnovas 2018-01-24 07:22:18 PST
(In reply to youenn fablet from comment #2)
> Does not apply.

Dunno what happened, I'll rebase it once #182043 lands.
Comment 4 Manuel Rego Casasnovas 2018-01-24 08:01:14 PST
Created attachment 332165 [details]
Rebased patch
Comment 5 Manuel Rego Casasnovas 2018-01-24 08:24:44 PST
The message about "patch does not apply to trunk of repository" seems misleading, it can be related to the size of the patch (due to moving so many files).

I was getting the same message in #182043 before landing.
Comment 6 youenn fablet 2018-01-24 13:06:28 PST
Comment on attachment 332165 [details]
Rebased patch

r =me as long as the bots are happy.
If you cannot run the bots on these ones, please make sure to looks at waterfall to ensure that no test expectation translation was missed.

Patch is not too big though, so there is probably another issue.
Comment 7 Manuel Rego Casasnovas 2018-01-24 22:59:32 PST
Created attachment 332232 [details]
Patch for landing
Comment 8 Manuel Rego Casasnovas 2018-01-24 23:19:33 PST
Committed r227595: <https://trac.webkit.org/changeset/227595>
Comment 9 Radar WebKit Bug Importer 2018-01-24 23:20:41 PST
<rdar://problem/36856125>