Bug 182082

Summary: ASSERT(CGSizeEqualToSize(m_resizeScrollOffset, CGSizeZero)) in WebViewImpl::setFrameAndScrollBy()
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, eric.carlson, ews-watchlist, gustavo, mcatanzaro, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch none

Simon Fraser (smfr)
Reported 2018-01-24 19:10:57 PST
ASSERT(CGSizeEqualToSize(m_resizeScrollOffset, CGSizeZero)) in WebViewImpl::setFrameAndScrollBy()
Attachments
Patch (15.73 KB, patch)
2018-01-24 19:13 PST, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
Patch (17.71 KB, patch)
2018-01-25 09:46 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-01-24 19:13:46 PST
Created attachment 332219 [details] Patch
Tim Horton
Comment 2 2018-01-24 19:44:59 PST
Comment on attachment 332219 [details] Patch I think you’ll (probably) want to fix the other ports builds. Though it does seem like AcceleratedDrawingAreaProxy might use m_scrollOffset...
Simon Fraser (smfr)
Comment 3 2018-01-25 09:46:01 PST
Created attachment 332275 [details] Patch
EWS Watchlist
Comment 4 2018-01-25 09:48:17 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 5 2018-01-25 14:27:32 PST
Comment on attachment 332275 [details] Patch Clearing flags on attachment: 332275 Committed r227630: <https://trac.webkit.org/changeset/227630>
Eric Carlson
Comment 6 2018-01-26 07:20:58 PST
Comment on attachment 332275 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332275&action=review > Source/WebKit/ChangeLog:12 > + Rename to m_resizeScrollOffset to m_scrollOffsetAdjustment to reduce confusion with actual scroll offsets. Nit: Too many tos in "Rename to ... to ... to ..."
Radar WebKit Bug Importer
Comment 7 2018-01-31 08:53:25 PST
<rdar://problem/37072206>
Note You need to log in before you can comment on or make changes to this bug.