Bug 182067

Summary: Web Inspector: Simplify update-LegacyInspectorBackendCommands.rb
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, bburg, commit-queue, ews-watchlist, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2018-01-24 15:00:02 PST
Simplify update-LegacyInspectorBackendCommands.rb - It doesn't need to generate the InspectorBackendDispatcher/InspectorFrontendDispatcher - The dependency_json is no longer needed and always empty
Attachments
[PATCH] Proposed Fix (5.33 KB, patch)
2018-01-24 15:02 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (5.16 KB, patch)
2018-01-24 15:03 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2018-01-24 15:02:21 PST
Created attachment 332202 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2018-01-24 15:03:20 PST
Created attachment 332203 [details] [PATCH] Proposed Fix
EWS Watchlist
Comment 3 2018-01-24 15:06:21 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
EWS Watchlist
Comment 4 2018-01-24 15:06:33 PST
Attachment 332203 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:199: [generate_from_specification] Undefined variable 'JSBackendCommandsGenerator' [pylint/E0602] [5] WARNING: This machine could support 4 simulators, but is only configured for 3. WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>. Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Blaze Burg
Comment 5 2018-01-24 15:17:38 PST
Comment on attachment 332203 [details] [PATCH] Proposed Fix r=me but let's file a bug against EWS
Blaze Burg
Comment 6 2018-01-24 15:18:34 PST
(In reply to Build Bot from comment #4) > Attachment 332203 [details] did not pass style-queue: > > > ERROR: > Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings. > py:199: [generate_from_specification] Undefined variable > 'JSBackendCommandsGenerator' [pylint/E0602] [5] This is frivolous, pylint can't see into the glob import that imports this symbol. > WARNING: This machine could support 4 simulators, but is only configured for > 3. > WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>. > Total errors found: 1 in 5 files Um, that's strange.
Aakash Jain
Comment 7 2018-01-24 16:03:42 PST
> > WARNING: This machine could support 4 simulators, but is only configured for 3. > > WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>. > > Um, that's strange. https://bugs.webkit.org/show_bug.cgi?id=181702 should fix this.
Joseph Pecoraro
Comment 8 2018-01-24 16:06:21 PST
> > ERROR: > > Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings. > > py:199: [generate_from_specification] Undefined variable > > 'JSBackendCommandsGenerator' [pylint/E0602] [5] > > This is frivolous, pylint can't see into the glob import that imports this symbol. <https://webkit.org/b/182071> check-webkit-style: False positive python undefined variable pylon warning - linter doesn't seem to follow includes > > WARNING: This machine could support 4 simulators, but is only configured for 3. > > WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>. > > Total errors found: 1 in 5 files > > Um, that's strange. <https://webkit.org/b/181702> webkit-patch upload emits irrelevant simulator warnings
WebKit Commit Bot
Comment 9 2018-01-24 16:22:33 PST
Comment on attachment 332203 [details] [PATCH] Proposed Fix Clearing flags on attachment: 332203 Committed r227586: <https://trac.webkit.org/changeset/227586>
WebKit Commit Bot
Comment 10 2018-01-24 16:22:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.