Bug 182063

Summary: [Curl] Implement didSendData client callback.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: WebCore Misc.Assignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, commit-queue, don.olmstead, ews-watchlist, galpeter, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Basuke Suzuki
Reported 2018-01-24 14:18:08 PST
Curl port didn't have this implementation. Now we have.
Attachments
Patch (4.35 KB, patch)
2018-01-24 14:21 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-01-24 14:21:43 PST
Created attachment 332199 [details] Patch
Alex Christensen
Comment 2 2018-01-24 14:28:36 PST
Comment on attachment 332199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332199&action=review > Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.cpp:190 > + m_handle->client()->didSendData(m_handle, bytesSent, totalBytesToBeSent); You might want to check these for null.
Don Olmstead
Comment 3 2018-01-24 14:33:04 PST
Comment on attachment 332199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332199&action=review >> Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.cpp:190 >> + m_handle->client()->didSendData(m_handle, bytesSent, totalBytesToBeSent); > > You might want to check these for null. Looks like cancelledOrClientless does that correct Basuke?
Basuke Suzuki
Comment 4 2018-01-24 16:00:54 PST
Null check was done in callClient utility method. It is also guarded by protectThis.
Basuke Suzuki
Comment 5 2018-01-24 16:01:55 PST
Oh, I misunderstood the point. I'm checking.
Basuke Suzuki
Comment 6 2018-01-24 16:04:06 PST
Don is correct. It was checked by cancelledOrClientless().
WebKit Commit Bot
Comment 7 2018-01-24 20:13:00 PST
Comment on attachment 332199 [details] Patch Clearing flags on attachment: 332199 Committed r227591: <https://trac.webkit.org/changeset/227591>
WebKit Commit Bot
Comment 8 2018-01-24 20:13:01 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-01-24 20:14:06 PST
<rdar://problem/36853125>
Note You need to log in before you can comment on or make changes to this bug.