Bug 182047

Summary: [Mac][WebVR] Add the build machinery for in-tree OpenVR
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: achristensen, darin, dino, fred.wang, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 177298    
Attachments:
Description Flags
WIP
none
WIP
none
WIP
none
WIP none

Sergio Villar Senin
Reported 2018-01-24 07:27:00 PST
OpenVR was added to the tree in bug 177298. I tried to add the required information to get it building in MacOS but I was totally unable to do it without also affecting iOS. I'd need a Mac build system expert here. I'm attaching what I've done so far just int case it could be used.
Attachments
WIP (4.97 KB, patch)
2018-01-24 07:29 PST, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
WIP (37.60 KB, patch)
2018-01-24 07:32 PST, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
WIP (34.59 KB, patch)
2018-10-01 02:45 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
WIP (38.71 KB, patch)
2018-10-01 11:16 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2018-01-24 07:29:57 PST
Created attachment 332161 [details] WIP
Sergio Villar Senin
Comment 2 2018-01-24 07:32:08 PST
Created attachment 332162 [details] WIP
Alex Christensen
Comment 3 2018-01-25 10:46:36 PST
FYI, you can add most of the build system, but we probably won't want to build it by default with make or build-webkit until we decide to enable the feature.
Sergio Villar Senin
Comment 4 2018-01-26 00:47:08 PST
(In reply to Alex Christensen from comment #3) > FYI, you can add most of the build system, but we probably won't want to > build it by default with make or build-webkit until we decide to enable the > feature. I'm fine with that. I just don't know how to do all that (and also disable it for iOS) on Xcode. That's why I'd be more than happy to see some other taking this over for me.
Frédéric Wang (:fredw)
Comment 5 2018-10-01 02:45:44 PDT
Created attachment 351229 [details] WIP Just trying to rebase Sergio's patch...
Frédéric Wang (:fredw)
Comment 6 2018-10-01 11:16:27 PDT
Created attachment 351277 [details] WIP This adds more headers to XCode. Then compilation fails because of a warning ( https://github.com/ValveSoftware/openvr/pull/898 ) and link fails because of duplicated symbols (e.g. jsoncpp already exists in webrtc).
Sergio Villar Senin
Comment 7 2020-07-05 23:49:04 PDT
OpenVR was removed from tree. Same happened with WebVR code. Closing now.
Note You need to log in before you can comment on or make changes to this bug.