Summary: | [Mac][WebVR] Add the build machinery for in-tree OpenVR | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED WONTFIX | ||||||||||||
Severity: | Normal | CC: | achristensen, darin, dino, fred.wang, simon.fraser, thorton | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 177298 | ||||||||||||
Attachments: |
|
Description
Sergio Villar Senin
2018-01-24 07:27:00 PST
Created attachment 332161 [details]
WIP
Created attachment 332162 [details]
WIP
FYI, you can add most of the build system, but we probably won't want to build it by default with make or build-webkit until we decide to enable the feature. (In reply to Alex Christensen from comment #3) > FYI, you can add most of the build system, but we probably won't want to > build it by default with make or build-webkit until we decide to enable the > feature. I'm fine with that. I just don't know how to do all that (and also disable it for iOS) on Xcode. That's why I'd be more than happy to see some other taking this over for me. Created attachment 351229 [details]
WIP
Just trying to rebase Sergio's patch...
Created attachment 351277 [details] WIP This adds more headers to XCode. Then compilation fails because of a warning ( https://github.com/ValveSoftware/openvr/pull/898 ) and link fails because of duplicated symbols (e.g. jsoncpp already exists in webrtc). OpenVR was removed from tree. Same happened with WebVR code. Closing now. |