Bug 182031

Summary: [GTK] Use GDK_EVENT_PROPAGATE and GDK_EVENT_STOP in WebKitWebViewBase.cpp
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cgarcia, commit-queue, ews-watchlist, gustavo, mcatanzaro
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2018-01-23 17:56:38 PST
GDK_EVENT_PROPAGATE and GDK_EVENT_STOP were added in GTK+ 3.4, and we require GTK+ 3.6. We should use them in WebKitWebViewBase to make the event handlers a bit easier to read.
Attachments
Patch (7.60 KB, patch)
2018-01-23 18:01 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-01-23 18:01:05 PST
Created attachment 332111 [details] Patch
EWS Watchlist
Comment 2 2018-01-23 18:01:50 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2018-01-24 07:25:18 PST
Comment on attachment 332111 [details] Patch Clearing flags on attachment: 332111 Committed r227519: <https://trac.webkit.org/changeset/227519>
WebKit Commit Bot
Comment 4 2018-01-24 07:25:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.