Bug 182030

Summary: Layout Test http/tests/workers/service/basic-unregister-then-register-again-reuse.html is flaky
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: Service WorkersAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, lforschler, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Matt Lewis
Reported 2018-01-23 17:34:51 PST
The following layout test is flaky on macOS WK2 http/tests/workers/service/basic-unregister-then-register-again-reuse.html Probable cause: This seems to have recently started. The change in https://trac.webkit.org/changeset/227275/webkit is related via service workers, however it doesn't seem to be a cause. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fworkers%2Fservice%2Fbasic-unregister-then-register-again-reuse.html Diff: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/workers/service/basic-unregister-then-register-again-reuse-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/workers/service/basic-unregister-then-register-again-reuse-actual.txt @@ -1,5 +1,5 @@ PASS: registration1 should not have an installing worker PASS: registration1 should not have a waiting worker PASS: registration1 should have an active worker -PASS: Registration was reused +FAIL: Registration was not reused
Attachments
Patch (1.96 KB, patch)
2018-01-24 11:54 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-23 17:37:05 PST
<rdar://problem/36802933>
Brady Eidson
Comment 2 2018-01-24 00:00:18 PST
(In reply to Matt Lewis from comment #0) > The following layout test is flaky on macOS WK2 > > http/tests/workers/service/basic-unregister-then-register-again-reuse.html > > Probable cause: > > This seems to have recently started. The change in > https://trac.webkit.org/changeset/227275/webkit is related via service > workers, however it doesn't seem to be a cause. 227275 is not related to SW - it was a no-behavior-change for SW> > > Flakiness Dashboard: > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=http%2Ftests%2Fworkers%2Fservice%2Fbasic- > unregister-then-register-again-reuse.html > > Diff: > > --- > /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/ > http/tests/workers/service/basic-unregister-then-register-again-reuse- > expected.txt > +++ > /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/ > http/tests/workers/service/basic-unregister-then-register-again-reuse-actual. > txt > @@ -1,5 +1,5 @@ > PASS: registration1 should not have an installing worker > PASS: registration1 should not have a waiting worker > PASS: registration1 should have an active worker > -PASS: Registration was reused > +FAIL: Registration was not reused
Chris Dumez
Comment 3 2018-01-24 10:50:36 PST
Will try and look into this today.
Chris Dumez
Comment 4 2018-01-24 11:54:07 PST
Created attachment 332183 [details] Patch
WebKit Commit Bot
Comment 5 2018-01-24 13:26:51 PST
Comment on attachment 332183 [details] Patch Clearing flags on attachment: 332183 Committed r227557: <https://trac.webkit.org/changeset/227557>
WebKit Commit Bot
Comment 6 2018-01-24 13:26:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.