Bug 182021

Summary: Add a IPC::SendSyncOption indicating we should not process incoming IPC while waiting for the sync reply
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bshafiei, commit-queue, ggaren, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=184183
Attachments:
Description Flags
WIP Patch
none
Patch none

Chris Dumez
Reported 2018-01-23 15:46:25 PST
Add a IPC::SendSyncOption indicating we should not process incoming IPC while waiting for the sync reply. This can be used in places where we know it would definitely not be safe to re-enter WebCore during a sendSync() call.
Attachments
WIP Patch (6.88 KB, patch)
2018-01-23 16:06 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (21.51 KB, patch)
2018-01-24 10:27 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-01-23 16:06:56 PST
Created attachment 332091 [details] WIP Patch
Babak Shafiei
Comment 2 2018-01-23 16:54:19 PST
<rdar://problem/21629943>
Radar WebKit Bug Importer
Comment 3 2018-01-23 16:54:55 PST
<rdar://problem/36801024>
Babak Shafiei
Comment 4 2018-01-23 16:57:20 PST
<rdar://problem/21629943>
Chris Dumez
Comment 5 2018-01-24 10:00:30 PST
Passes all the layout tests locally as well with a syncSync() timeout of infinity. Will add a layout test and reupload. I'll also audit all 3 IPC recipient to validate that they do not do a sync IPC to the WebProcess before responding to the WebProcess' sync IPC.
Chris Dumez
Comment 6 2018-01-24 10:27:43 PST
Created attachment 332177 [details] Patch
Chris Dumez
Comment 7 2018-01-24 14:00:38 PST
Comment on attachment 332177 [details] Patch Clearing flags on attachment: 332177 Committed r227566: <https://trac.webkit.org/changeset/227566>
Chris Dumez
Comment 8 2018-01-24 14:00:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.