| Summary: | check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
| Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, darin, ews-watchlist, glenn, lforschler, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 332081 [details]
Patch v1
Comment on attachment 332081 [details] Patch v1 Attachment 332081 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6189452 New failing tests: http/tests/misc/bubble-drag-events.html Created attachment 332117 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
(In reply to Build Bot from comment #3) > Comment on attachment 332081 [details] > Patch v1 > > Attachment 332081 [details] did not pass win-ews (win): > Output: http://webkit-queues.webkit.org/results/6189452 > > New failing tests: > http/tests/misc/bubble-drag-events.html FYI: There is no possible way this patch can cause a Windows layout test failure as it only changes Python code used by check-webkit-style. Comment on attachment 332081 [details] Patch v1 Clearing flags on attachment: 332081 Committed r227532: <https://trac.webkit.org/changeset/227532> All reviewed patches have been landed. Closing bug. |
This code which contains a block argument with a return type: [delegate setPolicyForURL:^_WKWebsitePolicy(NSURL *url) { return _WKWebsitePolicyDoIt; }]; Triggers a false-positive warning like this: Place brace on its own line for function definitions. [whitespace/braces] [4]