Bug 181994

Summary:

AX: SVG AAM mapping trumps ARIA role attribute in the case of SVG root

Product:

WebKit

Reporter:

Joanmarie Diggs <jdiggs>

Component:

Accessibility

Assignee:

Joanmarie Diggs <jdiggs>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, rniwa, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews105 for mac-sierra-wk2	none
Archive of layout-test-results from ews113 for mac-sierra	none
Patch	none
Archive of layout-test-results from ews206 for win-future	none
Patch	none

Joanmarie Diggs

Reported 2018-01-23 10:52:58 PST

We're unconditionally mapping the SVG root to AccessibilityRole::Group as per the SVG AAM. Doing so means any author-provided ARIA role on the SVG root is lost.

Attachments
Patch (5.09 KB, patch) 2018-01-23 10:55 PST, Joanmarie Diggs	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.21 MB, application/zip) 2018-01-23 11:55 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews105 for mac-sierra-wk2 (2.68 MB, application/zip) 2018-01-23 12:00 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-sierra (2.89 MB, application/zip) 2018-01-23 12:20 PST, EWS Watchlist	no flags	Details
Patch (5.97 KB, patch) 2018-01-24 07:23 PST, Joanmarie Diggs	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews206 for win-future (12.04 MB, application/zip) 2018-01-24 09:25 PST, EWS Watchlist	no flags	Details
Patch (6.76 KB, patch) 2018-01-24 09:55 PST, Joanmarie Diggs	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-01-23 10:53:26 PST

<rdar://problem/36783421>

Joanmarie Diggs

Comment 2 2018-01-23 10:55:12 PST

Created attachment 332039 [details] Patch

EWS Watchlist

Comment 3 2018-01-23 11:55:29 PST

Comment on attachment 332039 [details] Patch Attachment 332039 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6184614 New failing tests: accessibility/svg-element-with-aria-role.html

EWS Watchlist

Comment 4 2018-01-23 11:55:30 PST

Created attachment 332051 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-01-23 12:00:38 PST

Comment on attachment 332039 [details] Patch Attachment 332039 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6184633 New failing tests: accessibility/svg-element-with-aria-role.html

EWS Watchlist

Comment 6 2018-01-23 12:00:40 PST

Created attachment 332056 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-01-23 12:20:46 PST

Comment on attachment 332039 [details] Patch Attachment 332039 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6184664 New failing tests: accessibility/svg-element-with-aria-role.html

EWS Watchlist

Comment 8 2018-01-23 12:20:47 PST

Created attachment 332059 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6

chris fleizach

Comment 9 2018-01-23 17:56:51 PST

(In reply to Joanmarie Diggs (irc: joanie) from comment #2) > Created attachment 332039 [details] > Patch Approved once failing test is resolved

Joanmarie Diggs

Comment 10 2018-01-24 07:23:22 PST

Created attachment 332159 [details] Patch

Joanmarie Diggs

Comment 11 2018-01-24 09:10:03 PST

Comment on attachment 332159 [details] Patch Note that I generated test results for macOS and Linux. I don't have a machine on which to do so for Windows.

EWS Watchlist

Comment 12 2018-01-24 09:25:07 PST

Comment on attachment 332159 [details] Patch Attachment 332159 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6196465 New failing tests: http/tests/misc/bubble-drag-events.html accessibility/svg-element-with-aria-role.html

EWS Watchlist

Comment 13 2018-01-24 09:25:18 PST

Created attachment 332172 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Joanmarie Diggs

Comment 14 2018-01-24 09:55:05 PST

Created attachment 332174 [details] Patch

Joanmarie Diggs

Comment 15 2018-01-24 09:57:45 PST

(In reply to Build Bot from comment #12) > New failing tests: > http/tests/misc/bubble-drag-events.html I don't see how this patch can be causing the above. > accessibility/svg-element-with-aria-role.html Looks like all SVG accessibility tests are marked as failing for windows. Therefore my just-attached patch adds the new test to that list in TestExpectations.

WebKit Commit Bot

Comment 16 2018-01-24 11:34:55 PST

Comment on attachment 332174 [details] Patch Clearing flags on attachment: 332174 Committed r227536: <https://trac.webkit.org/changeset/227536>

WebKit Commit Bot

Comment 17 2018-01-24 11:34:57 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.