Bug 181993

Summary:

REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Text

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, ews-watchlist, hyatt, mitz, mmaxfield, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar, Regression

Version:

WebKit Local Build

Hardware:

All

OS:

All

URL:

data:text/html,<p%20style="font-family:%20-apple-system">12&zwj;</p>

See Also:

https://bugs.webkit.org/show_bug.cgi?id=181964
https://bugs.webkit.org/show_bug.cgi?id=182022

Bug Depends on:

180984

Bug Blocks:

Attachments:

Description	Flags
Patch and layout test	none
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Archive of layout-test-results from ews112 for mac-sierra	none
Patch and layout test	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews114 for mac-sierra	none
Patch and layout test	none

Daniel Bates

Reported 2018-01-23 10:47:26 PST

When using certain fonts (e.g. -apple-system on macOS) selecting a line that end with a zero-width joiner (ZWJ) may cause a text transformation of the character before the ZWJ. On macOS you can observe this issue by performing the following: 1. Visit <data:text/html,<p%20style="font-family:%20-apple-system">12&zwj;</p>>. 2. Select the '2'. Then the '2' will transform to Ä. But it should not transform at all and remain '2'.

Attachments
Patch and layout test (20.71 KB, patch) 2018-01-23 10:50 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-sierra (2.20 MB, application/zip) 2018-01-23 11:50 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.51 MB, application/zip) 2018-01-23 11:55 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-sierra (2.90 MB, application/zip) 2018-01-23 12:21 PST, EWS Watchlist	no flags	Details
Patch and layout test (21.27 KB, patch) 2018-01-23 16:24 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.29 MB, application/zip) 2018-01-23 17:21 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.74 MB, application/zip) 2018-01-23 17:31 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-sierra (2.90 MB, application/zip) 2018-01-23 17:55 PST, EWS Watchlist	no flags	Details
Patch and layout test (21.19 KB, patch) 2018-01-23 20:50 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2018-01-23 10:50:31 PST

Created attachment 332038 [details] Patch and layout test

Daniel Bates

Comment 2 2018-01-23 10:51:08 PST

<rdar://problem/36421080>

Daniel Bates

Comment 3 2018-01-23 10:52:54 PST

Ideally we need to fix bug #181964 so that selection and zero-width joiners interact well.

EWS Watchlist

Comment 4 2018-01-23 11:50:26 PST

Comment on attachment 332038 [details] Patch and layout test Attachment 332038 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6184541 New failing tests: fast/text/mac/select-character-before-zero-width-joiner.html

EWS Watchlist

Comment 5 2018-01-23 11:50:27 PST Comment hidden (obsolete)

Created attachment 332049 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-01-23 11:55:46 PST Comment hidden (obsolete)

Comment on attachment 332038 [details] Patch and layout test Attachment 332038 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6184580 New failing tests: fast/text/mac/select-character-before-zero-width-joiner.html

EWS Watchlist

Comment 7 2018-01-23 11:55:47 PST Comment hidden (obsolete)

Created attachment 332052 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-01-23 12:21:02 PST Comment hidden (obsolete)

Comment on attachment 332038 [details] Patch and layout test Attachment 332038 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6184642 New failing tests: fast/text/mac/select-character-before-zero-width-joiner.html

EWS Watchlist

Comment 9 2018-01-23 12:21:04 PST Comment hidden (obsolete)

Created attachment 332060 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6

Daniel Bates

Comment 10 2018-01-23 16:23:21 PST

(In reply to Build Bot from comment #4) > Comment on attachment 332038 [details] > Patch and layout test > > Attachment 332038 [details] did not pass mac-ews (mac): > Output: http://webkit-queues.webkit.org/results/6184541 > > New failing tests: > fast/text/mac/select-character-before-zero-width-joiner.html This test failure is because I inadvertently wrote the expected file taking advantage of bug #181964 (only occurs on macOS High Sierra). On another note the actual rendering of this test on macOS Sierra is wrong. See bug #182022 for more details.

Daniel Bates

Comment 11 2018-01-23 16:24:14 PST

Created attachment 332093 [details] Patch and layout test

EWS Watchlist

Comment 12 2018-01-23 17:21:57 PST Comment hidden (obsolete)

Comment on attachment 332093 [details] Patch and layout test Attachment 332093 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6188482 New failing tests: fast/text/mac/select-character-before-zero-width-joiner.html

EWS Watchlist

Comment 13 2018-01-23 17:21:59 PST Comment hidden (obsolete)

Created attachment 332104 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 14 2018-01-23 17:31:42 PST Comment hidden (obsolete)

Comment on attachment 332093 [details] Patch and layout test Attachment 332093 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6188592 New failing tests: fast/text/mac/select-character-before-zero-width-joiner.html

EWS Watchlist

Comment 15 2018-01-23 17:31:44 PST Comment hidden (obsolete)

Created attachment 332107 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 16 2018-01-23 17:54:59 PST Comment hidden (obsolete)

Comment on attachment 332093 [details] Patch and layout test Attachment 332093 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6188665 New failing tests: fast/text/mac/select-character-before-zero-width-joiner.html

EWS Watchlist

Comment 17 2018-01-23 17:55:00 PST Comment hidden (obsolete)

Created attachment 332110 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6

Daniel Bates

Comment 18 2018-01-23 20:50:52 PST

Created attachment 332120 [details] Patch and layout test

Dave Hyatt

Comment 19 2018-01-24 11:10:12 PST

Comment on attachment 332120 [details] Patch and layout test r=me

Daniel Bates

Comment 20 2018-01-24 11:17:34 PST

Comment on attachment 332120 [details] Patch and layout test Clearing flags on attachment: 332120 Committed r227533: <https://trac.webkit.org/changeset/227533>

Daniel Bates

Comment 21 2018-01-24 11:17:36 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.