Bug 181976

Summary: Re-arrange TypedArray JSTypes to match the order of the TypedArrayType enum list.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. fpizlo: review+

Mark Lam
Reported 2018-01-23 00:49:17 PST
This simplifies the code and makes it easier to map from one to the other.
Attachments
proposed patch. (18.60 KB, patch)
2018-01-23 11:18 PST, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-23 00:50:33 PST
<rdar://problem/36766936>
Mark Lam
Comment 2 2018-01-23 11:18:58 PST
Created attachment 332043 [details] proposed patch.
EWS Watchlist
Comment 3 2018-01-23 11:20:15 PST
Attachment 332043 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/TypedArrayType.h:59: Code inside a namespace should not be indented. [whitespace/indent] [4] WARNING: This machine could support 4 simulators, but is only configured for 3. WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>. Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 4 2018-01-23 12:40:14 PST
Thanks for the review. Landed in r227434: <http://trac.webkit.org/r227434>.
Yusuke Suzuki
Comment 5 2018-01-23 23:04:12 PST
Committed r227478: <https://trac.webkit.org/changeset/227478>
Note You need to log in before you can comment on or make changes to this bug.