Bug 181961

Summary:

Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, cdumez, cgarcia, dbates, ews-watchlist, galpeter, gustavo, japhet, mcatanzaro, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Alex Christensen

Reported 2018-01-22 16:31:32 PST

Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync

Attachments
Patch (34.61 KB, patch) 2018-01-22 16:33 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (35.76 KB, patch) 2018-01-22 17:05 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (35.90 KB, patch) 2018-01-22 18:00 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (36.31 KB, patch) 2018-01-23 12:19 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (36.14 KB, patch) 2018-01-23 13:37 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (37.63 KB, patch) 2018-01-23 14:33 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2018-01-22 16:33:11 PST

Created attachment 331976 [details] Patch

Alex Christensen

Comment 2 2018-01-22 17:05:48 PST

Created attachment 331981 [details] Patch

Michael Catanzaro

Comment 3 2018-01-22 17:58:22 PST

Comment on attachment 331981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331981&action=review This looks easier to read! r=me if you can get it past the Windows EWS. > Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:217 > + didReceiveResponse(ResourceResponse(d->m_response), [this, protectedThis = makeRef(*this)] { Failed to run "['perl', 'Tools\\Scripts\\build-webkit', '--release', '--wincairo', '--64-bit']" exit_code: 1 oid (void)> &&)': cannot convert argument 2 from 'WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential::<lambda_af02a6328e703639d69ef207f72ddd9e>' to 'WTF::CompletionHandler<void (void)> &&' ..\..\Source\WebCore\platform\network\curl\ResourceHandleCurl.cpp(222): note: Reason: cannot convert from 'WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential::<lambda_af02a6328e703639d69ef207f72ddd9e>' to 'WTF::CompletionHandler<void (void)>' ..\..\Source\WebCore\platform\network\curl\ResourceHandleCurl.cpp(222): note: use of undefined type 'WTF::CompletionHandler<void (void)>' C:\WebKit-EWS\WebKit\Source\WebCore\platform\network\ResourceHandle.h(110): note: see declaration of 'WTF::CompletionHandler<void (void)>'

Alex Christensen

Comment 4 2018-01-22 18:00:57 PST

Created attachment 331991 [details] Patch

Alex Christensen

Comment 5 2018-01-23 12:19:25 PST

Created attachment 332058 [details] Patch

Alex Christensen

Comment 6 2018-01-23 13:37:24 PST

Created attachment 332068 [details] Patch

Alex Christensen

Comment 7 2018-01-23 14:33:55 PST

Created attachment 332078 [details] Patch