Bug 181955

Summary: Mac Sierra perf bots have been failing due to CG errors
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, ews-watchlist, glenn, koivisto, lforschler, mjs, ryanhaddad, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Ignores the erorr messages on macOS Sierra koivisto: review+

Ryosuke Niwa
Reported 2018-01-22 14:46:02 PST
All perf tests are failing due to CoreGraphics spewing errors
Attachments
Ignores the erorr messages on macOS Sierra (7.24 KB, patch)
2018-01-22 14:50 PST, Ryosuke Niwa 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-01-22 14:49:57 PST
We should make perf bots ignore all output except for the lines they expect.
Ryosuke Niwa
Comment 2 2018-01-22 14:50:23 PST
Created attachment 331966 [details] Ignores the erorr messages on macOS Sierra
Alexey Proskuryakov
Comment 3 2018-01-22 14:55:51 PST
Comment on attachment 331966 [details] Ignores the erorr messages on macOS Sierra View in context: https://bugs.webkit.org/attachment.cgi?id=331966&action=review > Tools/Scripts/webkitpy/performance_tests/perftest.py:266 > + # GC errors on macOS 10.12.6 CG. These also happen on High Sierra, although we don't have any bots.
Ryosuke Niwa
Comment 4 2018-01-22 16:15:59 PST
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 331966 [details] > Ignores the erorr messages on macOS Sierra > > View in context: > https://bugs.webkit.org/attachment.cgi?id=331966&action=review > > > Tools/Scripts/webkitpy/performance_tests/perftest.py:266 > > + # GC errors on macOS 10.12.6 > > CG. These also happen on High Sierra, although we don't have any bots. Hm... I've tried it on my High Sierra machine, and I don't see the same errors.
Alexey Proskuryakov
Comment 5 2018-01-22 16:26:21 PST
Surprisingly, I don't seem to hit these on mine either. Okay. Probably best for someone with more Python knowledge than myself to review the patch.
Ryosuke Niwa
Comment 6 2018-01-23 16:30:09 PST
Committed r227460: <https://trac.webkit.org/changeset/227460>
Radar WebKit Bug Importer
Comment 7 2018-01-23 16:31:36 PST
<rdar://problem/36799878>
Note You need to log in before you can comment on or make changes to this bug.