Bug 181909

Summary: Fix broken unit-tests after r227192
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, cgarcia, commit-queue, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=181787
Attachments:
Description Flags
Proposed patch none

Description Aakash Jain 2018-01-20 16:02:23 PST 
https://trac.webkit.org/changeset/227192/webkit broke few unit-tests. e.g.:

FAIL: test_builder GTK Linux 64-bit Release (Tests) (__main__.BuildStepsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./steps_unittest.py", line 488, in doTest
    self.assertListEqual(expected_build_steps[builder['name']], buildSteps)
AssertionError: Lists differ: ['configure build', 'svn', 'ki... != ['configure build', 'svn', 'ki...

Second list contains 1 additional elements.
First extra element 19:
webdriver-test

  ['configure build',
   'svn',
   'kill old processes',
   'delete WebKitBuild directory',
   'delete stale build files',
   'jhbuild',
   'download-built-product',
   'extract-built-product',
   'jscore-test',
   'layout-test',
   'webkitpy-test',
   'webkitperl-test',
   'bindings-generation-tests',
   'builtins-generator-tests',
   'dashboard-tests',
   'archive-test-results',
   'upload',
   'MasterShellCommand',
-  'API tests']
?             ^

+  'API tests',
?             ^

+  'webdriver-test']
Comment 1 Aakash Jain 2018-01-20 16:04:41 PST 
Created attachment 331849 [details]
Proposed patch
Comment 2 Carlos Garcia Campos 2018-01-21 00:33:43 PST 
Comment on attachment 331849 [details]
Proposed patch

Sorry, I didn't notice it. Thanks for fixing it.
Comment 3 WebKit Commit Bot 2018-01-21 00:57:21 PST 
Comment on attachment 331849 [details]
Proposed patch

Clearing flags on attachment: 331849

Committed r227276: <https://trac.webkit.org/changeset/227276>
Comment 4 WebKit Commit Bot 2018-01-21 00:57:22 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-01-21 00:58:27 PST 
<rdar://problem/36704843>