Bug 181906 – Extend 'ifBuilt' config key to set property based on whether certain repositories are built or not.

• Component: New Bugs
• Status: RESOLVED FIXED

Extend 'ifBuilt' config key to set property based on whether certain repositories are built or not.

Created attachment 331839 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 331839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331839&action=review

> Websites/perf.webkit.org/ChangeLog:9
> +        'ifBuilt' need to conditionally set property based on whether certain required repositories are built.
> +        Empty required repository list means no requirement on repository to set property.

Please explain why we're making this change in the change log.

> Websites/perf.webkit.org/tools/js/buildbot-syncer.js:287
> +                    const meetRepositoryRequirement = repositoryRequirement.length === 0 || repositoryRequirement.some((repository) => commitSet.requiresBuildForRepository(repository));

Use !repositoryRequirement.length instead of === 0.

> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:1075
> +        it('should resolve "ifBuilt" with repositories to check', () => {

Should be rephrased as: should set the value for "ifBuilt" if the repository in the list appears.

> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:1103
> +        it('should resolve "ifBuilt" with if only owned commits need build', () => {

Should re be rephrase as: should not set the value for "ifBuilt" if owned commits of a repository not in the list appears.

[Ahmad Saleem]

This seems to have landed in below commit:

https://github.com/WebKit/WebKit/commit/fb6ec544c9b743866d117b10ccf57fecac6893e6

and not backed out. I am marking this as "RESOLVED FIXED". Thanks!

Yes, it is. Thanks!