Bug 181895

Summary: Temporarily restore block selection code conditionally
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, simon.fraser, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch thorton: review+

Megan Gardner
Reported 2018-01-19 18:12:37 PST
Temporarily restore some selection methods
Attachments
Patch (33.19 KB, patch)
2018-01-19 19:52 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (33.19 KB, patch)
2018-01-20 19:52 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (33.88 KB, patch)
2018-01-22 11:33 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (34.55 KB, patch)
2018-01-22 12:55 PST, Megan Gardner 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2018-01-19 19:52:26 PST
Created attachment 331829 [details] Patch
Megan Gardner
Comment 2 2018-01-19 19:53:43 PST
<rdar://problem/36567325>
Tim Horton
Comment 3 2018-01-19 21:35:10 PST
Comment on attachment 331829 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331829&action=review > Source/WebKit/Platform/spi/ios/UIKitSPI.h:618 > +- (void)changeBlockSelectionWithTouchAt:(CGPoint)point withSelectionTouch:(UIWKSelectionTouch)touch forHandle:(UIWKHandlePosition)handle; Semicolons and curly braces and stuff oh my!
Megan Gardner
Comment 4 2018-01-20 19:52:08 PST
Created attachment 331855 [details] Patch
Tim Horton
Comment 5 2018-01-21 11:05:07 PST
Still doesn’t build.
Wenson Hsieh
Comment 6 2018-01-21 14:06:33 PST
Looks like we need to re-teach UIKitSPI.h about UIWKHandlePosition.
Simon Fraser (smfr)
Comment 7 2018-01-22 10:29:52 PST
Can we add a test?
Megan Gardner
Comment 8 2018-01-22 11:33:02 PST
Created attachment 331945 [details] Patch
Megan Gardner
Comment 9 2018-01-22 12:55:20 PST
Created attachment 331951 [details] Patch
Tim Horton
Comment 10 2018-01-22 13:04:21 PST
Comment on attachment 331951 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331951&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2638 > + // This was only readded to avoid a crash due to incombatabliltiese with certain version of UIKit. > incombatabliltiese
Megan Gardner
Comment 11 2018-01-22 13:51:53 PST
https://trac.webkit.org/changeset/227355/webkit
Megan Gardner
Comment 12 2018-01-22 17:46:28 PST
https://trac.webkit.org/changeset/227377/webkit
Note You need to log in before you can comment on or make changes to this bug.