Bug 181892

Summary: Add a new logging specialization for count data
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED WONTFIX    
Severity: Normal CC: aakash_jain, cdumez, dbates, ews-watchlist, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Brent Fulgham
Reported 2018-01-19 17:32:38 PST
WebKit telemetry data is currently captured as strings in many cases, which can make evaluating the data difficult. We should take advantage of the native logging infrastructure's ability to handle integer types, and pass counts as integers.
Attachments
Patch (29.52 KB, patch)
2018-01-19 17:38 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (35.22 KB, patch)
2018-01-21 12:15 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (35.22 KB, patch)
2018-01-21 12:47 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-19 17:35:58 PST
<rdar://problem/36677978>
Brent Fulgham
Comment 2 2018-01-19 17:38:53 PST
Created attachment 331826 [details] Patch
Brent Fulgham
Comment 3 2018-01-21 12:15:27 PST
Created attachment 331877 [details] Patch
Brent Fulgham
Comment 4 2018-01-21 12:44:57 PST
Comment on attachment 331877 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331877&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:45 > +- (void)_webView:(WKWebView *)webView logDiagnosticMessageWithCount:(NSString *)message description:(NSString *)description count:(NSUInteger) count WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); Whoops! This should be uint64_t for consistency.
Brent Fulgham
Comment 5 2018-01-21 12:47:10 PST
Created attachment 331880 [details] Patch
Brent Fulgham
Comment 6 2018-01-22 15:48:54 PST
I talked to Chris about this (he wrote the initial code), and we decided this should be addressed on the Safari side. I'll close this as NTBF.
Note You need to log in before you can comment on or make changes to this bug.