Bug 181889

Summary:

Disallow evaluating JavaScript from NPP_Destroy() in WebKit

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebKit2

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, ap, bfulgham, ews-watchlist, koivisto, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=48929
https://bugs.webkit.org/show_bug.cgi?id=176881
https://bugs.webkit.org/show_bug.cgi?id=41431
https://bugs.webkit.org/show_bug.cgi?id=128712

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Patch	none

Daniel Bates

Reported 2018-01-19 16:03:40 PST

Disallow evaluating JavaScript from NPP_Destroy() in WebKit.

Attachments
Patch (13.19 KB, patch) 2018-01-19 16:10 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (13.25 KB, patch) 2018-01-19 16:15 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.04 MB, application/zip) 2018-01-19 17:13 PST, EWS Watchlist	no flags	Details
Patch (15.24 KB, patch) 2018-02-02 20:49 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-01-19 16:05:55 PST

<rdar://problem/36674701>

Daniel Bates

Comment 2 2018-01-19 16:10:29 PST

Created attachment 331806 [details] Patch

Daniel Bates

Comment 3 2018-01-19 16:13:52 PST

Evaluating of JavaScript from NPP_Destroy() was disallowed in WebKitLegacy on macOS since <https://trac.webkit.org/changeset/42789/> and has been racy in WebKit since <https://trac.webkit.org/changeset/164015> (bug #128712).

Daniel Bates

Comment 4 2018-01-19 16:15:00 PST

Created attachment 331808 [details] Patch

Brent Fulgham

Comment 5 2018-01-19 16:59:08 PST

Comment on attachment 331808 [details] Patch It seems bad to allow this in the first place. r=mews.

EWS Watchlist

Comment 6 2018-01-19 17:13:16 PST Comment hidden (obsolete)

Comment on attachment 331808 [details] Patch Attachment 331808 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6142909 New failing tests: plugins/npruntime/npruntime-calls-with-null-npp.html

EWS Watchlist

Comment 7 2018-01-19 17:13:17 PST Comment hidden (obsolete)

Created attachment 331824 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Daniel Bates

Comment 8 2018-02-02 20:49:50 PST

Created attachment 333026 [details] Patch

Daniel Bates

Comment 9 2018-02-02 20:56:41 PST

Comment on attachment 333026 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333026&action=review > Source/WebKit/ChangeLog:9 > + Make the behavior of WebKit match the behavior of WebKitLegacy on Mac. I will update this description to include the remarks I made in comment #3 before landing.

Brent Fulgham

Comment 10 2018-02-02 21:16:08 PST

Comment on attachment 333026 [details] Patch R=me

Daniel Bates

Comment 11 2018-02-05 10:04:03 PST

Comment on attachment 333026 [details] Patch Clearing flags on attachment: 333026 Committed r228100: <https://trac.webkit.org/changeset/228100>

Daniel Bates

Comment 12 2018-02-05 10:04:05 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.