| Summary: | Disallow evaluating JavaScript from NPP_Destroy() in WebKit | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||||
| Component: | WebKit2 | Assignee: | Daniel Bates <dbates> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | andersca, ap, bfulgham, ews-watchlist, koivisto, rniwa, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Local Build | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=48929 https://bugs.webkit.org/show_bug.cgi?id=176881 https://bugs.webkit.org/show_bug.cgi?id=41431 https://bugs.webkit.org/show_bug.cgi?id=128712 |
||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Daniel Bates
2018-01-19 16:03:40 PST
Created attachment 331806 [details]
Patch
Evaluating of JavaScript from NPP_Destroy() was disallowed in WebKitLegacy on macOS since <https://trac.webkit.org/changeset/42789/> and has been racy in WebKit since <https://trac.webkit.org/changeset/164015> (bug #128712). Created attachment 331808 [details]
Patch
Comment on attachment 331808 [details]
Patch
It seems bad to allow this in the first place. r=mews.
Comment on attachment 331808 [details] Patch Attachment 331808 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6142909 New failing tests: plugins/npruntime/npruntime-calls-with-null-npp.html Created attachment 331824 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 333026 [details]
Patch
Comment on attachment 333026 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333026&action=review > Source/WebKit/ChangeLog:9 > + Make the behavior of WebKit match the behavior of WebKitLegacy on Mac. I will update this description to include the remarks I made in comment #3 before landing. Comment on attachment 333026 [details]
Patch
R=me
Comment on attachment 333026 [details] Patch Clearing flags on attachment: 333026 Committed r228100: <https://trac.webkit.org/changeset/228100> All reviewed patches have been landed. Closing bug. |