Bug 181876

Summary: [Curl] Add timeout support to XMLHttpRequest
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: WebCore Misc.Assignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, commit-queue, don.olmstead, ews-watchlist, galpeter, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117300    
Attachments:
Description Flags
Patch
achristensen: review+, achristensen: commit-queue-
Fixed none

Basuke Suzuki
Reported 2018-01-19 13:10:29 PST
Add timeout support to XMLHttpRequest
Attachments
Patch (5.60 KB, patch)
2018-01-19 13:15 PST, Basuke Suzuki 		achristensen: review+
achristensen: commit-queue-
DetailsFormatted DiffDiff
Fixed (5.57 KB, patch)
2018-01-19 13:27 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-01-19 13:15:21 PST
Created attachment 331775 [details] Patch
Alex Christensen
Comment 2 2018-01-19 13:22:10 PST
Comment on attachment 331775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331775&action=review > Source/WebCore/platform/network/ResourceRequestBase.cpp:36 > -#if !USE(SOUP) && (!PLATFORM(MAC) || USE(CFURLCONNECTION)) > +#if !USE(SOUP) && (!PLATFORM(MAC) || USE(CFURLCONNECTION)) && !USE(CURL) Let's change this to #if PLATFORM(IOS) || USE(CFURLCONNECTION)
Basuke Suzuki
Comment 3 2018-01-19 13:27:35 PST
Created attachment 331782 [details] Fixed Okay, change the ifdef condition much simpler
WebKit Commit Bot
Comment 4 2018-01-19 14:33:56 PST
Comment on attachment 331782 [details] Fixed Clearing flags on attachment: 331782 Committed r227237: <https://trac.webkit.org/changeset/227237>
WebKit Commit Bot
Comment 5 2018-01-19 14:33:57 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-01-19 14:34:23 PST
<rdar://problem/36671458>
Note You need to log in before you can comment on or make changes to this bug.