Bug 181876

Summary: [Curl] Add timeout support to XMLHttpRequest
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: WebCore Misc.Assignee: Basuke Suzuki <Basuke.Suzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, Basuke.Suzuki, commit-queue, don.olmstead, ews-watchlist, galpeter, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117300    
Attachments:
Description Flags
Patch
achristensen: review+, achristensen: commit-queue-
Fixed none

Description Basuke Suzuki 2018-01-19 13:10:29 PST 
Add timeout support to XMLHttpRequest
Comment 1 Basuke Suzuki 2018-01-19 13:15:21 PST 
Created attachment 331775 [details]
Patch
Comment 2 Alex Christensen 2018-01-19 13:22:10 PST 
Comment on attachment 331775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331775&action=review

> Source/WebCore/platform/network/ResourceRequestBase.cpp:36
> -#if !USE(SOUP) && (!PLATFORM(MAC) || USE(CFURLCONNECTION))
> +#if !USE(SOUP) && (!PLATFORM(MAC) || USE(CFURLCONNECTION)) && !USE(CURL)

Let's change this to #if PLATFORM(IOS) || USE(CFURLCONNECTION)
Comment 3 Basuke Suzuki 2018-01-19 13:27:35 PST 
Created attachment 331782 [details]
Fixed

Okay, change the ifdef condition much simpler
Comment 4 WebKit Commit Bot 2018-01-19 14:33:56 PST 
Comment on attachment 331782 [details]
Fixed

Clearing flags on attachment: 331782

Committed r227237: <https://trac.webkit.org/changeset/227237>
Comment 5 WebKit Commit Bot 2018-01-19 14:33:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-01-19 14:34:23 PST 
<rdar://problem/36671458>