Bug 181847

Summary:	[GTK] TERM environment variable is not passed to the test driver.
Product:	WebKit	Reporter:	Carlos Alberto Lopez Perez <clopez>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply, cgarcia, lforschler, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified

Carlos Alberto Lopez Perez

Reported 2018-01-19 04:15:40 PST

The TERM environment variable is used to tell the capabilities of the terminal to the running process. On most of the GTK/WPE bots we set this to TERM=dumb so the tests don't generate ANSI color codes that just look bad on the txt/html files generated by buildbot and make reading the results harder. We noticed color codes are happening on the new webdriver tests even with this variable. It looks we are not letting the driver pick this variable, so when pytest is invoked it can't see it. https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/5131/steps/webdriver-test/logs/stdio

Attachments
Add attachment proposed patch, testcase, etc.

Carlos Alberto Lopez Perez

Comment 1 2018-01-19 04:22:09 PST

Committed r227195: <https://trac.webkit.org/changeset/227195>

Radar WebKit Bug Importer

Comment 2 2018-01-19 04:23:20 PST

<rdar://problem/36654987>

Note You need to log in before you can comment on or make changes to this bug.