Bug 181826

Summary: [Cocoa] Support font collections
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186086
Attachments:
Description Flags
Needs test
none
Patch
none
Patch
none
Patch none

Myles C. Maxfield
Reported 2018-01-18 18:45:25 PST
[Cocoa] Support font collections
Attachments
Needs test (14.52 KB, patch)
2018-01-18 18:46 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (15.34 KB, patch)
2018-01-18 19:09 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (15.68 KB, patch)
2018-01-18 19:25 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (15.70 KB, patch)
2018-01-18 19:37 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2018-01-18 18:46:25 PST
Created attachment 331690 [details] Needs test
Myles C. Maxfield
Comment 2 2018-01-18 18:46:58 PST
<rdar://problem/36455137>
EWS Watchlist
Comment 3 2018-01-18 18:47:39 PST
Attachment 331690 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:9: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Myles C. Maxfield
Comment 4 2018-01-18 19:09:56 PST
Created attachment 331692 [details] Patch
Myles C. Maxfield
Comment 5 2018-01-18 19:19:41 PST
https://github.com/w3c/csswg-drafts/issues/2205
Myles C. Maxfield
Comment 6 2018-01-18 19:25:55 PST
Created attachment 331697 [details] Patch
Myles C. Maxfield
Comment 7 2018-01-18 19:37:46 PST
Created attachment 331701 [details] Patch
Dean Jackson
Comment 8 2018-01-19 14:41:51 PST
Comment on attachment 331701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331701&action=review > Source/WebCore/ChangeLog:30 > + No new tests because I don't have a font collection file with the appropriate license for the > + WebKit repository. I tested manually. Can we create one?
Myles C. Maxfield
Comment 9 2018-01-22 18:03:30 PST
Comment on attachment 331701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331701&action=review >> Source/WebCore/ChangeLog:30 >> + WebKit repository. I tested manually. > > Can we create one? Yeah, I just haven't done it yet.
WebKit Commit Bot
Comment 10 2018-01-22 18:09:29 PST
Comment on attachment 331701 [details] Patch Clearing flags on attachment: 331701 Committed r227381: <https://trac.webkit.org/changeset/227381>
WebKit Commit Bot
Comment 11 2018-01-22 18:09:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.