Bug 181803

Summary: [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
Product: WebKit Reporter: mitz
Component: Tools / TestsAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, dino, eric.carlson, ews-watchlist, graouts, keith_miller, kondapallykalyan, lforschler, mark.lam, msaboff, saam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
First cut
none
Add and adopt macOSTargetConditionals.xcconfig thorton: review+

mitz
Reported 2018-01-18 10:51:28 PST
Introduce a family of helper build settings that make it easier to define build settings whose value depends on the target macOS version without having to update those definitions in the future.
Attachments
First cut (81.44 KB, patch)
2018-01-18 10:52 PST, mitz 		no flags
DetailsFormatted DiffDiff
Add and adopt macOSTargetConditionals.xcconfig (90.03 KB, patch)
2018-01-18 11:37 PST, mitz 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2018-01-18 10:52:09 PST
Created attachment 331642 [details] First cut
EWS Watchlist
Comment 2 2018-01-18 10:54:06 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
mitz
Comment 3 2018-01-18 11:37:15 PST
Created attachment 331645 [details] Add and adopt macOSTargetConditionals.xcconfig
Alex Christensen
Comment 4 2018-01-18 11:49:44 PST
Comment on attachment 331645 [details] Add and adopt macOSTargetConditionals.xcconfig Are we going to do something similar with iOS?
mitz
Comment 5 2018-01-18 11:50:42 PST
Committed <https://trac.webkit.org/r227156>.
Radar WebKit Bug Importer
Comment 6 2018-01-18 11:51:40 PST
<rdar://problem/36628533>
mitz
Comment 7 2018-01-18 11:51:54 PST
(In reply to Alex Christensen from comment #4) > Comment on attachment 331645 [details] > Add and adopt macOSTargetConditionals.xcconfig > > Are we going to do something similar with iOS? I don’t anticipate that we will, because we have never supported building for iOS with deployment target ≠ SDK version.
Radar WebKit Bug Importer
Comment 8 2018-01-18 11:53:00 PST
<rdar://problem/36628581>
Note You need to log in before you can comment on or make changes to this bug.