Bug 181782

Summary: Fix perf dashboard tests for node v8
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dewei_zhu, lforschler, rniwa, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the tests
none
Fixes the tests none

Ryosuke Niwa
Reported 2018-01-17 21:42:12 PST
There are some test failures in the latest LTS of node.js. Fix them all.
Attachments
Fixes the tests (deleted)
2018-01-17 21:50 PST, Ryosuke Niwa 		no flags
Details
Fixes the tests (7.93 KB, patch)
2018-01-17 21:55 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-01-17 21:50:59 PST
Created attachment 331592 [details] Fixes the tests
Lucas Forschler
Comment 2 2018-01-17 21:54:11 PST
The content of attachment 331592 [details] has been deleted for the following reason: incorrect
Ryosuke Niwa
Comment 3 2018-01-17 21:55:18 PST
Created attachment 331593 [details] Fixes the tests
Wenson Hsieh
Comment 4 2018-01-17 21:59:07 PST
Comment on attachment 331593 [details] Fixes the tests rs=me
Ryosuke Niwa
Comment 5 2018-01-17 22:06:51 PST
Comment on attachment 331593 [details] Fixes the tests Clearing flags on attachment: 331593 Committed r227122: <https://trac.webkit.org/changeset/227122>
Ryosuke Niwa
Comment 6 2018-01-17 22:06:53 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-01-17 22:14:42 PST
<rdar://problem/36608851>
Note You need to log in before you can comment on or make changes to this bug.