Bug 181778

Summary:

AppCache: Log a Deprecation warning to the Console when AppCache is used

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Page Loading

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, commit-queue, ews-watchlist, joepeck, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	ews-watchlist: commit-queue-
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Archive of layout-test-results from ews112 for mac-sierra	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
[PATCH] Proposed Fix	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews114 for mac-sierra	none
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none

Joseph Pecoraro

Reported 2018-01-17 19:46:12 PST

AppCache: Log a Deprecation warning to the Console when AppCache is used Suggest using ServiceWorkers instead now that AppCache is deprecated.

Attachments
[PATCH] Proposed Fix (60.90 KB, patch) 2018-01-17 19:47 PST, Joseph Pecoraro	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.24 MB, application/zip) 2018-01-17 20:47 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.64 MB, application/zip) 2018-01-17 20:53 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-sierra (2.93 MB, application/zip) 2018-01-17 21:16 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.18 MB, application/zip) 2018-01-17 21:19 PST, EWS Watchlist	no flags	Details
[PATCH] Proposed Fix (63.98 KB, patch) 2018-01-18 11:05 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.31 MB, application/zip) 2018-01-18 12:07 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-sierra (3.03 MB, application/zip) 2018-01-18 12:37 PST, EWS Watchlist	no flags	Details
Patch (63.58 KB, patch) 2018-01-19 10:14 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.34 MB, application/zip) 2018-01-19 11:03 PST, EWS Watchlist	no flags	Details
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2018-01-17 19:47:24 PST

Created attachment 331580 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 2 2018-01-17 19:48:48 PST

Comment on attachment 331580 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=331580&action=review > LayoutTests/http/tests/appcache/deferred-events-expected.txt:1 > -CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response. > +CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead. This test is already marked as flakey for all ports: > LayoutTests/TestExpectations:933:webkit.org/b/87633 http/tests/appcache/deferred-events.html [ Pass Failure ] So I'm going to assume that the destructive change is just fine.

EWS Watchlist

Comment 3 2018-01-17 20:47:20 PST Comment hidden (obsolete)

Comment on attachment 331580 [details] [PATCH] Proposed Fix Attachment 331580 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6115802 New failing tests: http/tests/security/appcache-switching-private-browsing.html http/tests/appcache/load-from-appcache-defer-resume-crash.html http/tests/appcache/auth.html

EWS Watchlist

Comment 4 2018-01-17 20:47:21 PST Comment hidden (obsolete)

Created attachment 331585 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-01-17 20:53:30 PST Comment hidden (obsolete)

Comment on attachment 331580 [details] [PATCH] Proposed Fix Attachment 331580 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6115811 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/appcache-ordering-main.https.html

EWS Watchlist

Comment 6 2018-01-17 20:53:32 PST Comment hidden (obsolete)

Created attachment 331586 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-01-17 21:16:10 PST Comment hidden (obsolete)

Comment on attachment 331580 [details] [PATCH] Proposed Fix Attachment 331580 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6115852 New failing tests: http/tests/security/appcache-switching-private-browsing.html http/tests/appcache/load-from-appcache-defer-resume-crash.html http/tests/appcache/auth.html

EWS Watchlist

Comment 8 2018-01-17 21:16:11 PST Comment hidden (obsolete)

Created attachment 331590 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 9 2018-01-17 21:19:24 PST Comment hidden (obsolete)

Comment on attachment 331580 [details] [PATCH] Proposed Fix Attachment 331580 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6115854 New failing tests: http/tests/security/appcache-switching-private-browsing.html http/tests/appcache/decide-navigation-policy-after-delay.html http/tests/contentfiltering/load-substitute-data-from-appcache.html imported/w3c/web-platform-tests/service-workers/service-worker/appcache-ordering-main.https.html

EWS Watchlist

Comment 10 2018-01-17 21:19:25 PST Comment hidden (obsolete)

Created attachment 331591 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Joseph Pecoraro

Comment 11 2018-01-18 11:05:48 PST

Created attachment 331643 [details] [PATCH] Proposed Fix

EWS Watchlist

Comment 12 2018-01-18 12:06:58 PST

Comment on attachment 331643 [details] [PATCH] Proposed Fix Attachment 331643 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6123889 New failing tests: http/tests/appcache/load-from-appcache-defer-resume-crash.html imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-preflight.any.html http/tests/appcache/auth.html

EWS Watchlist

Comment 13 2018-01-18 12:07:00 PST

Created attachment 331647 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 14 2018-01-18 12:37:49 PST

Comment on attachment 331643 [details] [PATCH] Proposed Fix Attachment 331643 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6123903 New failing tests: http/tests/appcache/load-from-appcache-defer-resume-crash.html http/tests/appcache/auth.html

EWS Watchlist

Comment 15 2018-01-18 12:37:51 PST

Created attachment 331650 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6

Alex Christensen

Comment 16 2018-01-19 10:14:04 PST

Created attachment 331747 [details] Patch

EWS Watchlist

Comment 17 2018-01-19 11:03:56 PST

Comment on attachment 331747 [details] Patch Attachment 331747 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6137548 New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-preflight.any.worker.html

EWS Watchlist

Comment 18 2018-01-19 11:03:57 PST

Created attachment 331756 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

Joseph Pecoraro

Comment 19 2018-01-19 11:28:54 PST

Comment on attachment 331747 [details] Patch Failure was unrelated, cq+ again.

WebKit Commit Bot

Comment 20 2018-01-19 11:54:08 PST

Comment on attachment 331747 [details] Patch Clearing flags on attachment: 331747 Committed r227225: <https://trac.webkit.org/changeset/227225>

WebKit Commit Bot

Comment 21 2018-01-19 11:54:10 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 22 2018-01-19 12:06:59 PST

<rdar://problem/36666643>

Note You need to log in before you can comment on or make changes to this bug.