| Summary: | AppCache: Log a Deprecation warning to the Console when AppCache is used | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> |
| Component: | Page Loading | Assignee: | Joseph Pecoraro <joepeck> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | achristensen, beidson, commit-queue, ews-watchlist, joepeck, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Attachments: | |||
|
Description
Joseph Pecoraro
2018-01-17 19:46:12 PST
Created attachment 331580 [details]
[PATCH] Proposed Fix
Comment on attachment 331580 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=331580&action=review > LayoutTests/http/tests/appcache/deferred-events-expected.txt:1 > -CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response. > +CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead. This test is already marked as flakey for all ports: > LayoutTests/TestExpectations:933:webkit.org/b/87633 http/tests/appcache/deferred-events.html [ Pass Failure ] So I'm going to assume that the destructive change is just fine. Comment on attachment 331580 [details] [PATCH] Proposed Fix Attachment 331580 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6115802 New failing tests: http/tests/security/appcache-switching-private-browsing.html http/tests/appcache/load-from-appcache-defer-resume-crash.html http/tests/appcache/auth.html Created attachment 331585 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 331580 [details] [PATCH] Proposed Fix Attachment 331580 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6115811 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/appcache-ordering-main.https.html Created attachment 331586 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 331580 [details] [PATCH] Proposed Fix Attachment 331580 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6115852 New failing tests: http/tests/security/appcache-switching-private-browsing.html http/tests/appcache/load-from-appcache-defer-resume-crash.html http/tests/appcache/auth.html Created attachment 331590 [details]
Archive of layout-test-results from ews112 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 331580 [details] [PATCH] Proposed Fix Attachment 331580 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6115854 New failing tests: http/tests/security/appcache-switching-private-browsing.html http/tests/appcache/decide-navigation-policy-after-delay.html http/tests/contentfiltering/load-substitute-data-from-appcache.html imported/w3c/web-platform-tests/service-workers/service-worker/appcache-ordering-main.https.html Created attachment 331591 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 331643 [details]
[PATCH] Proposed Fix
Comment on attachment 331643 [details] [PATCH] Proposed Fix Attachment 331643 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6123889 New failing tests: http/tests/appcache/load-from-appcache-defer-resume-crash.html imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-preflight.any.html http/tests/appcache/auth.html Created attachment 331647 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 331643 [details] [PATCH] Proposed Fix Attachment 331643 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6123903 New failing tests: http/tests/appcache/load-from-appcache-defer-resume-crash.html http/tests/appcache/auth.html Created attachment 331650 [details]
Archive of layout-test-results from ews114 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 331747 [details]
Patch
Comment on attachment 331747 [details] Patch Attachment 331747 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6137548 New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-preflight.any.worker.html Created attachment 331756 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 331747 [details]
Patch
Failure was unrelated, cq+ again.
Comment on attachment 331747 [details] Patch Clearing flags on attachment: 331747 Committed r227225: <https://trac.webkit.org/changeset/227225> All reviewed patches have been landed. Closing bug. |