Bug 181774

Summary: clean up pushToSaveImmediateWithoutTouchingRegisters a bit
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch none

Description Saam Barati 2018-01-17 18:07:23 PST 
...
Comment 1 Saam Barati 2018-01-17 18:15:58 PST 
Created attachment 331570 [details]
patch
Comment 2 Saam Barati 2018-01-17 18:49:39 PST 
Created attachment 331576 [details]
patch
Comment 3 Saam Barati 2018-01-18 18:18:51 PST 
Created attachment 331686 [details]
patch
Comment 4 Saam Barati 2018-01-18 18:19:13 PST 
(In reply to Saam Barati from comment #3)
> Created attachment 331686 [details]
> patch

Updated to using dataTempRegister.
Comment 5 Saam Barati 2018-01-30 20:19:30 PST 
ping
Comment 6 JF Bastien 2018-01-30 21:03:44 PST 
Comment on attachment 331686 [details]
patch

r=me

Since the register doesn't matter it could totally be random... Though I guess it might lead to different GC values getting spilled sometimes? In that case data temp being on the stack is probably better than others.
Comment 7 Saam Barati 2018-01-30 21:38:32 PST 
(In reply to JF Bastien from comment #6)
> Comment on attachment 331686 [details]
> patch
> 
> r=me
> 
> Since the register doesn't matter it could totally be random... Though I
> guess it might lead to different GC values getting spilled sometimes? In
> that case data temp being on the stack is probably better than others.

Yeah it totally could be as long as it’s not a HW reserved register. An earlier incarnation of this patch chose x9 or x19 or something like that
Comment 8 WebKit Commit Bot 2018-01-31 02:05:02 PST 
Comment on attachment 331686 [details]
patch

Clearing flags on attachment: 331686

Committed r227897: <https://trac.webkit.org/changeset/227897>
Comment 9 WebKit Commit Bot 2018-01-31 02:05:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-01-31 02:06:27 PST 
<rdar://problem/37062583>