Bug 181774

Summary: clean up pushToSaveImmediateWithoutTouchingRegisters a bit
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch none

Saam Barati
Reported 2018-01-17 18:07:23 PST
...
Attachments
patch (1.77 KB, patch)
2018-01-17 18:15 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (1.89 KB, patch)
2018-01-17 18:49 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (2.00 KB, patch)
2018-01-18 18:18 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2018-01-17 18:15:58 PST
Created attachment 331570 [details] patch
Saam Barati
Comment 2 2018-01-17 18:49:39 PST
Created attachment 331576 [details] patch
Saam Barati
Comment 3 2018-01-18 18:18:51 PST
Created attachment 331686 [details] patch
Saam Barati
Comment 4 2018-01-18 18:19:13 PST
(In reply to Saam Barati from comment #3) > Created attachment 331686 [details] > patch Updated to using dataTempRegister.
Saam Barati
Comment 5 2018-01-30 20:19:30 PST
ping
JF Bastien
Comment 6 2018-01-30 21:03:44 PST
Comment on attachment 331686 [details] patch r=me Since the register doesn't matter it could totally be random... Though I guess it might lead to different GC values getting spilled sometimes? In that case data temp being on the stack is probably better than others.
Saam Barati
Comment 7 2018-01-30 21:38:32 PST
(In reply to JF Bastien from comment #6) > Comment on attachment 331686 [details] > patch > > r=me > > Since the register doesn't matter it could totally be random... Though I > guess it might lead to different GC values getting spilled sometimes? In > that case data temp being on the stack is probably better than others. Yeah it totally could be as long as it’s not a HW reserved register. An earlier incarnation of this patch chose x9 or x19 or something like that
WebKit Commit Bot
Comment 8 2018-01-31 02:05:02 PST
Comment on attachment 331686 [details] patch Clearing flags on attachment: 331686 Committed r227897: <https://trac.webkit.org/changeset/227897>
WebKit Commit Bot
Comment 9 2018-01-31 02:05:03 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-01-31 02:06:27 PST
<rdar://problem/37062583>
Note You need to log in before you can comment on or make changes to this bug.