Bug 181768

Summary:

[Curl] Use ResourceRequest::encodeWithPlatformData()

Product:

WebKit

Reporter:

Stephan Szabo <stephan.szabo>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, Basuke.Suzuki, commit-queue, don.olmstead, ews-watchlist, galpeter, pvollan, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Do not call encodeWithoutPlatformData() from encodePlatformData()	none
Do not call encodeWithoutPlatformData() from encodePlatformData() - fixed changelog	none

Description Stephan Szabo 2018-01-17 15:06:49 PST

encodeWithoutPlatformData() should not be called from encodePlatformData(), which results in assertion failures.
Instead we should make and use an encodeWithPlatformData().

Comment 1 Stephan Szabo 2018-01-17 15:33:46 PST

Created attachment 331547 [details]
Do not call encodeWithoutPlatformData() from encodePlatformData()

Comment 2 EWS Watchlist 2018-01-17 15:35:49 PST

Attachment 331547 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Stephan Szabo 2018-01-17 15:39:19 PST

Created attachment 331548 [details]
Do not call encodeWithoutPlatformData() from encodePlatformData() - fixed changelog

Comment 4 WebKit Commit Bot 2018-01-17 16:26:36 PST

Comment on attachment 331548 [details]
Do not call encodeWithoutPlatformData() from encodePlatformData() - fixed changelog

Clearing flags on attachment: 331548

Committed r227095: <https://trac.webkit.org/changeset/227095>

Comment 5 WebKit Commit Bot 2018-01-17 16:26:38 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2018-01-17 16:27:28 PST

<rdar://problem/36600584>