Bug 181760

Summary:

Fix broken unittest after r227048

Product:

WebKit

Reporter:

Ling Ho <lingcherd_ho>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, lforschler, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=181692

Attachments:

Description	Flags
Updated Queues from El Capitan to Sierra	aakash_jain: review+, commit-queue: commit-queue-
ChangeLog	aakash_jain: review-, aakash_jain: commit-queue-
steps_unittest.py and ChangeLog	none

Ling Ho

Reported 2018-01-17 12:38:20 PST

<https://trac.webkit.org/changeset/227048> resulted from https://bugs.webkit.org/show_bug.cgi?id=181692

Attachments
Updated Queues from El Capitan to Sierra (6.24 KB, patch) 2018-01-17 12:45 PST, Ling Ho	aakash_jain: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
ChangeLog (491 bytes, patch) 2018-01-17 14:07 PST, Ling Ho	aakash_jain: review- aakash_jain: commit-queue-	Details Formatted Diff Diff
steps_unittest.py and ChangeLog (7.93 KB, patch) 2018-01-17 14:29 PST, Ling Ho	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ling Ho

Comment 1 2018-01-17 12:45:20 PST

Created attachment 331533 [details] Updated Queues from El Capitan to Sierra

WebKit Commit Bot

Comment 2 2018-01-17 13:13:34 PST

Comment on attachment 331533 [details] Updated Queues from El Capitan to Sierra Rejecting attachment 331533 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 331533, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: org/git/WebKit b27a05ef82a..ecc55615907 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 227078 = b27a05ef82a93c9ff70dd30bf72d9ba11a2918a5 r227079 = ecc55615907980a2ab27df68230081bd5ce07838 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/6110081

Ling Ho

Comment 3 2018-01-17 14:07:41 PST

Created attachment 331538 [details] ChangeLog

Aakash Jain

Comment 4 2018-01-17 14:10:14 PST

Comment on attachment 331538 [details] ChangeLog Missing steps_unittest.py changes

Ling Ho

Comment 5 2018-01-17 14:29:34 PST

Created attachment 331543 [details] steps_unittest.py and ChangeLog

WebKit Commit Bot

Comment 6 2018-01-17 15:19:09 PST

Comment on attachment 331543 [details] steps_unittest.py and ChangeLog Clearing flags on attachment: 331543 Committed r227091: <https://trac.webkit.org/changeset/227091>

WebKit Commit Bot

Comment 7 2018-01-17 15:19:11 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2018-01-17 15:20:57 PST

<rdar://problem/36598262>

Note You need to log in before you can comment on or make changes to this bug.