Bug 181751

Summary: [GTK] Try even harder not to static link WTF into libwebkit2gtk
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bugs-noreply, mcatanzaro
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch achristensen: review+

Michael Catanzaro
Reported 2018-01-17 11:19:23 PST
Try even harder not to static link WTF into libwebkit2gtk. We don't want two copies of WTF. It should only be in libjavascriptcoregtk. Yesterday I found it was being linked into PAL. Today I noticed it's being linked directly into WebCore as well. Build systems are full of landmines.
Attachments
Patch (1.21 KB, patch)
2018-01-17 11:21 PST, Michael Catanzaro 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-01-17 11:20:01 PST
When we have this fully solved, then I *think* we should be able to turn on -fvisibility=hidden and -fvisibility-inlines=hidden again.
Michael Catanzaro
Comment 2 2018-01-17 11:21:08 PST
Created attachment 331524 [details] Patch
Michael Catanzaro
Comment 3 2018-01-17 11:22:58 PST
(In reply to Michael Catanzaro from comment #0) > Build systems are full of landmines. An interesting property of CMake build systems is that so long as anyone other than Konstantin is allowed to touch the build files, it will never work entirely as intended. I think I'm making some forward progress here, but perhaps I'm delusional....
Michael Catanzaro
Comment 4 2018-01-17 15:16:32 PST
Committed r227089: <https://trac.webkit.org/changeset/227089>
Note You need to log in before you can comment on or make changes to this bug.