Bug 181712

Summary: Remove Opensource El Capitan queues from buildbot
Product: WebKit Reporter: Ling Ho <lingcherd_ho>
Component: Tools / TestsAssignee: Ling Ho <lingcherd_ho>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, jlewis3, lforschler, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=181860
Attachments:
Description Flags
Patch
none
Updated ChangeLog
none
Patch none

Ling Ho
Reported 2018-01-16 17:55:38 PST
Remove Opesource El Capitan queues from buildbot
Attachments
Patch (18.88 KB, patch)
2018-01-17 15:29 PST, Ling Ho 		no flags
DetailsFormatted DiffDiff
Updated ChangeLog (18.90 KB, patch)
2018-01-17 16:57 PST, Ling Ho 		no flags
DetailsFormatted DiffDiff
Patch (18.95 KB, patch)
2018-01-18 10:26 PST, Ling Ho 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ling Ho
Comment 1 2018-01-17 15:29:04 PST
Created attachment 331546 [details] Patch
Ryan Haddad
Comment 2 2018-01-17 16:47:24 PST
Comment on attachment 331546 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331546&action=review Aside from the changelog, this looks good. > Tools/ChangeLog:7 > + As discussed in person, you can use the prepare-ChangeLog script to generate this entry for you. It will also add the changed files.
Aakash Jain
Comment 3 2018-01-17 16:54:11 PST
Comment on attachment 331546 [details] Patch r+ with ChangeLog fixed.
Ling Ho
Comment 4 2018-01-17 16:57:40 PST
Created attachment 331563 [details] Updated ChangeLog
Ryan Haddad
Comment 5 2018-01-18 09:52:48 PST
Comment on attachment 331563 [details] Updated ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=331563&action=review > Tools/ChangeLog:5 > + Reviewed by Aakash Jain. There should be an empty line between the bug URL and reviewer.
Ling Ho
Comment 6 2018-01-18 10:26:40 PST
Created attachment 331637 [details] Patch
WebKit Commit Bot
Comment 7 2018-01-18 11:01:30 PST
Comment on attachment 331637 [details] Patch Clearing flags on attachment: 331637 Committed r227154: <https://trac.webkit.org/changeset/227154>
WebKit Commit Bot
Comment 8 2018-01-18 11:01:32 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-01-18 11:02:38 PST
<rdar://problem/36626538>
Note You need to log in before you can comment on or make changes to this bug.