Bug 181706

Summary: Web Inspector: Canvas tab: typing a "space" in the QuickConsole shouldn't trigger a recording
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 175485    
Attachments:
Description Flags
Patch none

Description Matt Baker 2018-01-16 14:23:27 PST 
Summary:
Typing a "space" in the QuickConsole shouldn't trigger a recording. CanvasOverviewContentView should prevent this and allow the default behavior when an editable field has the focus (like TimelineTabContentView).

Steps to Reproduce:
1. Goto any page with a canvas
2. Open Canvas tab
3. Focus the QuickConsole prompt, type a space
  => Canvas recording is triggered
Comment 1 Radar WebKit Bug Importer 2018-01-16 14:23:43 PST 
<rdar://problem/36558221>
Comment 2 Matt Baker 2018-01-16 14:28:30 PST 
Created attachment 331432 [details]
Patch
Comment 3 Joseph Pecoraro 2018-01-16 15:02:21 PST 
Comment on attachment 331432 [details]
Patch

Nice! r=me
Comment 4 WebKit Commit Bot 2018-01-16 15:17:40 PST 
Comment on attachment 331432 [details]
Patch

Clearing flags on attachment: 331432

Committed r227008: <https://trac.webkit.org/changeset/227008>
Comment 5 WebKit Commit Bot 2018-01-16 15:17:42 PST 
All reviewed patches have been landed.  Closing bug.