Bug 181694

Summary: Web Inspector: Network Tab - Export HAR Context Menu not working
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2018-01-16 11:22:57 PST
Network Tab - Export HAR Context Menu not working Steps to Reproduce: 1. Inspect this page 2. Show Network Tab 3. Reload 4. Right Click a Resource > Select "Export HAR" => Doesn't do anything [Error] Uncaught exception in inspector page under contextMenuItemSelected TypeError: this._HARResources is not a function. (In 'this._HARResources()', 'this._HARResources' is undefined) _exportHAR — NetworkTableContentView.js:1386 _itemSelected — ContextMenu.js:238 contextMenuItemSelected — ContextMenu.js:175 contextMenuItemSelected — InspectorFrontendAPI.js:122
Attachments
[PATCH] Proposed Fix (19.15 KB, patch)
2018-01-16 11:23 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (1.55 KB, patch)
2018-01-16 11:34 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2018-01-16 11:23:06 PST
<rdar://problem/36479197>
Joseph Pecoraro
Comment 2 2018-01-16 11:23:48 PST
Created attachment 331406 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2018-01-16 11:27:11 PST
Rebasing.
Joseph Pecoraro
Comment 4 2018-01-16 11:34:10 PST
Created attachment 331407 [details] [PATCH] Proposed Fix
Blaze Burg
Comment 5 2018-01-16 11:57:20 PST
Comment on attachment 331407 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 6 2018-01-16 12:20:39 PST
Comment on attachment 331407 [details] [PATCH] Proposed Fix Clearing flags on attachment: 331407 Committed r226992: <https://trac.webkit.org/changeset/226992>
WebKit Commit Bot
Comment 7 2018-01-16 12:20:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.