Bug 181674

Summary:

[GTK][WPE] Improve the way glib tests are run

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, lforschler, webkit-bug-importer, zan

Priority:

Keywords:

Gtk, InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Carlos Garcia Campos 2018-01-16 01:14:33 PST

Stop using gtester external program and use our own tester from python directly. This way we no longer need to parse the tests output to get the results which is causing problems in WPE bot.

Comment 1 Carlos Garcia Campos 2018-01-16 01:22:08 PST

Created attachment 331372 [details]
Patch

Comment 2 EWS Watchlist 2018-01-16 01:24:36 PST

Attachment 331372 [details] did not pass style-queue:


ERROR: Tools/glib/glib_test_runner.py:257:  [GLibTestRunner.run] Instance of 'Popen' has no 'terminate' member  [pylint/E1101] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 WebKit Commit Bot 2018-01-16 02:42:53 PST

Comment on attachment 331372 [details]
Patch

Clearing flags on attachment: 331372

Committed r226967: <https://trac.webkit.org/changeset/226967>

Comment 4 WebKit Commit Bot 2018-01-16 02:42:55 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2018-01-16 02:43:22 PST

<rdar://problem/36539055>