Bug 181674

Summary: [GTK][WPE] Improve the way glib tests are run
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, lforschler, webkit-bug-importer, zan
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Carlos Garcia Campos
Reported Tuesday, January 16, 2018 9:14:33 AM UTC
Stop using gtester external program and use our own tester from python directly. This way we no longer need to parse the tests output to get the results which is causing problems in WPE bot.
Attachments
Patch (16.80 KB, patch)
2018-01-16 01:22 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 Tuesday, January 16, 2018 9:22:08 AM UTC
Created attachment 331372 [details] Patch
EWS Watchlist
Comment 2 Tuesday, January 16, 2018 9:24:36 AM UTC
Attachment 331372 [details] did not pass style-queue: ERROR: Tools/glib/glib_test_runner.py:257: [GLibTestRunner.run] Instance of 'Popen' has no 'terminate' member [pylint/E1101] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 Tuesday, January 16, 2018 10:42:53 AM UTC
Comment on attachment 331372 [details] Patch Clearing flags on attachment: 331372 Committed r226967: <https://trac.webkit.org/changeset/226967>
WebKit Commit Bot
Comment 4 Tuesday, January 16, 2018 10:42:55 AM UTC
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 Tuesday, January 16, 2018 10:43:22 AM UTC
<rdar://problem/36539055>
Note You need to log in before you can comment on or make changes to this bug.