Summary: | Test programs should only be built in developer mode | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | JavaScriptCore | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | annulen, bugs-noreply, cgarcia, commit-queue, mcatanzaro, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Michael Catanzaro
2018-01-15 11:59:44 PST
Created attachment 331350 [details]
Patch
These are unit tests, and it might make sense to build unit tests in non-developer builds, e.g. packagers could use them for smoke checking... You'd think, but our test scripts simply don't support running from tarball builds, and there's not much point in having a bunch of standalone test binaries in the builddir. That might be worth changing, of course. Comment on attachment 331350 [details] Patch Clearing flags on attachment: 331350 Committed r226971: <https://trac.webkit.org/changeset/226971> All reviewed patches have been landed. Closing bug. |