Bug 181653

Summary: Test programs should only be built in developer mode
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: JavaScriptCoreAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bugs-noreply, cgarcia, commit-queue, mcatanzaro, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2018-01-15 11:59:44 PST
JSC builds these test programs unconditionally: testmasm testb3 testair testapi But they're not exposed or installed in release mode. Our other tests all depend on developer mode, so let's be consistent. I noticed these recently because having installed binaries that depend on internal symbols of JSC makes it harder to change how we link JSC, though hopefully we'll never have to bother with that again anytime soon....
Attachments
Patch (1.65 KB, patch)
2018-01-15 12:00 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-01-15 12:00:51 PST
Created attachment 331350 [details] Patch
Konstantin Tokarev
Comment 2 2018-01-15 14:37:32 PST
These are unit tests, and it might make sense to build unit tests in non-developer builds, e.g. packagers could use them for smoke checking...
Michael Catanzaro
Comment 3 2018-01-15 15:21:46 PST
You'd think, but our test scripts simply don't support running from tarball builds, and there's not much point in having a bunch of standalone test binaries in the builddir. That might be worth changing, of course.
WebKit Commit Bot
Comment 4 2018-01-16 07:33:26 PST
Comment on attachment 331350 [details] Patch Clearing flags on attachment: 331350 Committed r226971: <https://trac.webkit.org/changeset/226971>
WebKit Commit Bot
Comment 5 2018-01-16 07:33:28 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-01-16 07:34:18 PST
<rdar://problem/36543176>
Note You need to log in before you can comment on or make changes to this bug.