Bug 181643

Summary: Clear Caches volatile storage as a memory optimization.
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, cgarcia, commit-queue, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2018-01-15 00:49:31 PST
Caches::m_volatileStorage is not cleared when clearing the memory representation. It should be done to release some memory.
Attachments
Patch (1.56 KB, patch)
2018-01-15 00:52 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-01-15 00:52:08 PST
Created attachment 331324 [details] Patch
Chris Dumez
Comment 2 2018-01-16 08:57:20 PST
Comment on attachment 331324 [details] Patch Is this really just a optimization? If the user asks to clear all data, then we try to read and return data from m_volatileStorage, wouldn't it be a bug?
WebKit Commit Bot
Comment 3 2018-01-17 01:22:40 PST
Comment on attachment 331324 [details] Patch Clearing flags on attachment: 331324 Committed r227052: <https://trac.webkit.org/changeset/227052>
WebKit Commit Bot
Comment 4 2018-01-17 01:22:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-01-17 01:23:55 PST
<rdar://problem/36576295>
Note You need to log in before you can comment on or make changes to this bug.