Bug 181630

Summary:

Remove makePoisonedUnique

Product:

WebKit

Reporter:

JF Bastien <jfbastien>

Component:

JavaScriptCore

Assignee:

JF Bastien <jfbastien>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, fpizlo, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	mark.lam: review+
patch	commit-queue: commit-queue-
patch	none

JF Bastien

Reported 2018-01-13 12:12:09 PST

I added a conversion from std::unique_ptr, so we can just use std::make_unique and it'll auto-poison when converted.

Attachments
patch (12.03 KB, patch) 2018-01-13 12:15 PST, JF Bastien	mark.lam: review+	Details Formatted Diff Diff
patch (16.00 KB, patch) 2018-01-14 09:03 PST, JF Bastien	commit-queue: commit-queue-	Details Formatted Diff Diff
patch (16.19 KB, patch) 2018-01-15 12:57 PST, JF Bastien	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-01-13 12:12:32 PST

<rdar://problem/36498623>

JF Bastien

Comment 2 2018-01-13 12:15:01 PST

Created attachment 331284 [details] patch

Mark Lam

Comment 3 2018-01-13 21:54:40 PST

Comment on attachment 331284 [details] patch r=me if you also fix the API tests and the EWS bots is green after that.

JF Bastien

Comment 4 2018-01-14 09:03:37 PST

Created attachment 331307 [details] patch Don't just build JSC!

WebKit Commit Bot

Comment 5 2018-01-14 09:04:48 PST

Comment on attachment 331307 [details] patch Rejecting attachment 331307 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 331307, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: s FAILED -- saving rejects to file Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp.rej patching file Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp Hunk #2 FAILED at 121. Hunk #3 FAILED at 134. 2 out of 3 hunks FAILED -- saving rejects to file Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/6070144

JF Bastien

Comment 6 2018-01-15 12:57:59 PST

Created attachment 331353 [details] patch Update to rebase on Mark's patch. The array version diverged a bunch from make_unique's version, so I removed it as well.

WebKit Commit Bot

Comment 7 2018-01-15 14:02:49 PST

Comment on attachment 331353 [details] patch Clearing flags on attachment: 331353 Committed r226956: <https://trac.webkit.org/changeset/226956>

WebKit Commit Bot

Comment 8 2018-01-15 14:02:51 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.