Bug 181629

Summary: [GTK] Shift + mouse scroll should scroll horizontally
Product: WebKit Reporter: Adam Dingle <adam>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cgarcia, ews-watchlist, gustavo, mcatanzaro
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugzilla.gnome.org/show_bug.cgi?id=731914
Attachments:
Description Flags
Patch mcatanzaro: review+

Adam Dingle
Reported 2018-01-12 22:52:39 PST
In WebKitGtk, if I hold down the shift key and scroll the mouse wheel, the window should scroll horizontally. (This would be consistent with the behavior in GNOME/GTK applications such as Evince and gedit.)
Attachments
Patch (7.50 KB, patch)
2018-02-01 04:14 PST, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Dingle
Comment 1 2018-01-12 22:54:32 PST
By the way, this bug was originally reported in Epiphany at https://bugzilla.gnome.org/show_bug.cgi?id=731914
Carlos Garcia Campos
Comment 2 2018-02-01 04:14:45 PST
Created attachment 332867 [details] Patch
EWS Watchlist
Comment 3 2018-02-01 04:16:44 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Michael Catanzaro
Comment 4 2018-02-01 07:58:11 PST
Comment on attachment 332867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332867&action=review > Source/WebCore/ChangeLog:8 > + We currently turn vertical scroll into horizontal when scrolling over the horizontal scrollbar. When Shit key is I hope you keyboard does not have a shit key!
Carlos Garcia Campos
Comment 5 2018-02-01 08:02:20 PST
(In reply to Michael Catanzaro from comment #4) > Comment on attachment 332867 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=332867&action=review > > > Source/WebCore/ChangeLog:8 > > + We currently turn vertical scroll into horizontal when scrolling over the horizontal scrollbar. When Shit key is > > I hope you keyboard does not have a shit key! http://atworkandbored.com/jokes-inc/fun-pics/oh-shit-key-4156.jpeg :-D
Carlos Garcia Campos
Comment 6 2018-02-01 08:04:19 PST
Committed r227966: <https://trac.webkit.org/changeset/227966>
Note You need to log in before you can comment on or make changes to this bug.