Bug 181629 – [GTK] Shift + mouse scroll should scroll horizontally

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Adam Dingle]

In WebKitGtk, if I hold down the shift key and scroll the mouse wheel, the window should scroll horizontally.

(This would be consistent with the behavior in GNOME/GTK applications such as Evince and gedit.)

[Adam Dingle]

By the way, this bug was originally reported in Epiphany at

https://bugzilla.gnome.org/show_bug.cgi?id=731914

[Carlos Garcia Campos]

Created attachment 332867 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Michael Catanzaro]

Comment on attachment 332867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332867&action=review

> Source/WebCore/ChangeLog:8
> +        We currently turn vertical scroll into horizontal when scrolling over the horizontal scrollbar. When Shit key is

I hope you keyboard does not have a shit key!

[Carlos Garcia Campos]

(In reply to Michael Catanzaro from comment #4)
> Comment on attachment 332867 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332867&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        We currently turn vertical scroll into horizontal when scrolling over the horizontal scrollbar. When Shit key is
> 
> I hope you keyboard does not have a shit key!

http://atworkandbored.com/jokes-inc/fun-pics/oh-shit-key-4156.jpeg

:-D

[Carlos Garcia Campos]

Committed r227966: <https://trac.webkit.org/changeset/227966>