Summary: | Web Inspector: Make Console's Execution Context picker stand out when it is non-default | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, nvasilyev, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2018-01-12 21:35:49 PST
Created attachment 331273 [details]
[IMAGE] Page Execution Context Unchanged
Created attachment 331274 [details]
[IMAGE] Non-Default Execution Context Highlight
Created attachment 331275 [details]
[PATCH] Proposed Fix
Comment on attachment 331275 [details] [PATCH] Proposed Fix Looks good, I like this! View in context: https://bugs.webkit.org/attachment.cgi?id=331275&action=review > Source/WebInspectorUI/UserInterface/Views/QuickConsole.css:102 > +.quick-console > .navigation-bar > .hierarchical-path.non-default-execution-context .execution-context { > + background: var(--selected-background-color); > + border-radius: 3px; > + color: white; Should we use `color: var(--selected-foreground-color);` since it's used for the arrows? Comment on attachment 331275 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=331275&action=review >> Source/WebInspectorUI/UserInterface/Views/QuickConsole.css:102 >> + color: white; > > Should we use `color: var(--selected-foreground-color);` since it's used for the arrows? Err, you're correct. And I do that down below. I think this line can be removed. Created attachment 331405 [details]
[PATCH] Proposed Fix
It was needed for the text portion of the picker (non-arrows). Updated to use the variable.
Comment on attachment 331275 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=331275&action=review r=me >>> Source/WebInspectorUI/UserInterface/Views/QuickConsole.css:102 >>> + color: white; >> >> Should we use `color: var(--selected-foreground-color);` since it's used for the arrows? > > Err, you're correct. And I do that down below. I think this line can be removed. Good catch! Comment on attachment 331405 [details] [PATCH] Proposed Fix Clearing flags on attachment: 331405 Committed r227003: <https://trac.webkit.org/changeset/227003> All reviewed patches have been landed. Closing bug. |