Bug 181628 – Web Inspector: Make Console's Execution Context picker stand out when it is non-default

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

Make Console's Execution Context picker stand out when it is non-default

Steps to reproduce:
1. Inspect <http://mdn.github.io/simple-web-worker/>
2. Toggle between "Page" and "Worker" in quick console
  => Easy to not realize you are in a Worker context.

[Radar WebKit Bug Importer]

<rdar://problem/36492044>

[Joseph Pecoraro]

Created attachment 331273 [details]
[IMAGE] Page Execution Context Unchanged

[Joseph Pecoraro]

Created attachment 331274 [details]
[IMAGE] Non-Default Execution Context Highlight

[Joseph Pecoraro]

Created attachment 331275 [details]
[PATCH] Proposed Fix

[Nikita Vasilyev]

Comment on attachment 331275 [details]
[PATCH] Proposed Fix

Looks good, I like this!

View in context: https://bugs.webkit.org/attachment.cgi?id=331275&action=review

> Source/WebInspectorUI/UserInterface/Views/QuickConsole.css:102
> +.quick-console > .navigation-bar > .hierarchical-path.non-default-execution-context .execution-context {
> +    background: var(--selected-background-color);
> +    border-radius: 3px;
> +    color: white;

Should we use `color: var(--selected-foreground-color);` since it's used for the arrows?

[Joseph Pecoraro]

Comment on attachment 331275 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=331275&action=review

>> Source/WebInspectorUI/UserInterface/Views/QuickConsole.css:102
>> +    color: white;
> 
> Should we use `color: var(--selected-foreground-color);` since it's used for the arrows?

Err, you're correct. And I do that down below. I think this line can be removed.

[Joseph Pecoraro]

Created attachment 331405 [details]
[PATCH] Proposed Fix

It was needed for the text portion of the picker (non-arrows). Updated to use the variable.

[Matt Baker]

Comment on attachment 331275 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=331275&action=review

r=me

>>> Source/WebInspectorUI/UserInterface/Views/QuickConsole.css:102
>>> +    color: white;
>> 
>> Should we use `color: var(--selected-foreground-color);` since it's used for the arrows?
> 
> Err, you're correct. And I do that down below. I think this line can be removed.

Good catch!

[WebKit Commit Bot]

Comment on attachment 331405 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 331405

Committed r227003: <https://trac.webkit.org/changeset/227003>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.