Bug 181626

Summary: [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jlewis3, joepeck, mitz, ryanhaddad, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Wenson Hsieh
Reported 2018-01-12 18:33:44 PST
WKAttachmentTests.ChangeAttachmentDataUpdatesWithInPlaceDisplay WKAttachmentTests.InPlaceVideoAttachmentInsertionWithinList Regressed after r226915. Test expectations just need to be rebaselined.
Attachments
Patch (3.59 KB, patch)
2018-01-12 19:04 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (4.78 KB, patch)
2018-01-12 20:48 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-01-12 19:04:33 PST
Created attachment 331270 [details] Patch
Wenson Hsieh
Comment 2 2018-01-12 20:48:49 PST
Created attachment 331272 [details] Patch
Joseph Pecoraro
Comment 3 2018-01-12 20:56:45 PST
Comment on attachment 331272 [details] Patch r=me
Wenson Hsieh
Comment 4 2018-01-12 21:08:09 PST
Thanks for the review!
WebKit Commit Bot
Comment 5 2018-01-12 21:31:01 PST
Comment on attachment 331272 [details] Patch Clearing flags on attachment: 331272 Committed r226935: <https://trac.webkit.org/changeset/226935>
WebKit Commit Bot
Comment 6 2018-01-12 21:31:02 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-01-12 21:32:37 PST
<rdar://problem/36492021>
Note You need to log in before you can comment on or make changes to this bug.